Closed Bug 505574 Opened 10 years ago Closed 10 years ago

OS/2 nsinstall.exe from moztools fails to install test directories recursively (after bug463417)

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
OS/2
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: wuno, Assigned: wuno)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

fix OS/2 v3 use os2-emx for HOST_OS_ARCH
1.52 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090715 Minefield/3.6a1pre
Build Identifier: 

Bug463417 changed in rules.mk
-# nsinstall in moztools can't recursively copy directories, so use nsinstall.py
-ifdef NSINSTALL_BIN
to
+ifeq (WINNT,$HOST_OS_ARCH)
+# Windows nsinstall can't recursively copy directories, so use nsinstall.py
While the former ifdef included the OS/2 nsinstall.exe (in moztools), the latter does not and therefore OS/2 nsinstall errors out, when trying to copy the first test directory recursively.
nsinstall: E:\usr\src\hg\mozilla-central\modules\libjar\zipwriter\test\unit\data is a directory
make.exe[6]: *** [libs] Error 3


Reproducible: Always
Assignee: nobody → wuno
Blocks: 463417
Version: unspecified → Trunk
Attached patch fix OS/2 (obsolete) — — Splinter Review
Attachment #389794 - Flags: review?(benjamin)
Attached patch fix OS/2 v2 (obsolete) — — Splinter Review 
s/OS_ARCH/HOST_OS_ARCH
Attachment #389794 - Attachment is obsolete: true
Attachment #389797 - Flags: review?(benjamin)
Attachment #389794 - Flags: review?(benjamin)
Argh, we use os2-emx together with HOST_OS_ARCH (not OS2, that's OS_ARCH). Sorry for the spam, its late here now...
Attachment #389797 - Attachment is obsolete: true
Attachment #389807 - Flags: review?(benjamin)
Attachment #389797 - Flags: review?(benjamin)
Attachment #389807 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7bd7a3ca22ca
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Keywords: regression
Target Milestone: --- → mozilla1.9.2a1
Status: RESOLVED → VERIFIED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.