[HTML5] Reduce amount of nsHtml5NamedCharacters generated code

RESOLVED FIXED

Status

()

enhancement
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mozilla+ben, Assigned: mozilla+ben)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

No longer depends on: 505599
Depends on: 505599
The previous patch changed the translator without changing the translated files.  This one reflects the new translation.  These patches should be landed together.

~/dev/debug/.hg/patches % diffstat -f 0 regenerate-named-characters-files.diff
 nsHtml5NamedCharacters.cpp      |17123 	24 +	17099 -	0 !
 nsHtml5NamedCharactersInclude.h | 2162 	2162 +	0 -	0 !
 2 files changed, 2186 insertions(+), 17099 deletions(-)
Henri, you've already reviewed the changes to GenerateNamedCharactersCpp.java.  This patch regenerates the C++ files and adds a Makefile target (make named_characters) to be run within parser/html/java/translator.
Attachment #389827 - Attachment is obsolete: true
Attachment #390950 - Attachment is obsolete: true
Attachment #395235 - Flags: review?(hsivonen)
Attachment #395235 - Flags: review?(hsivonen) → review+
Comment on attachment 395235 [details] [diff] [review]
Combined patch created after 'make sync'-ing from validator.nu repo

Looks good. (I didn't try compiling it.)
Attachment #395235 - Flags: superreview?(mrbkap)
Attachment #395235 - Flags: superreview?(mrbkap) → superreview+
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/0fb9c41b5d87
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.