505602 - [HTML5] Reduce amount of nsHtml5NamedCharacters generated code

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Ben Newman (:bnewman) (:benjamn)]

Attachment: Generating and #including nsHtml5NamedCharactersInclude.h four times

See explanation here:
http://bugzilla.validator.nu/show_bug.cgi?id=622#c0

Comment 1

[Ben Newman (:bnewman) (:benjamn)]

Attachment: Followup patch with regenerated nsHtml5NamedCharacters files

The previous patch changed the translator without changing the translated files.  This one reflects the new translation.  These patches should be landed together.

~/dev/debug/.hg/patches % diffstat -f 0 regenerate-named-characters-files.diff
 nsHtml5NamedCharacters.cpp      |17123 	24 +	17099 -	0 !
 nsHtml5NamedCharactersInclude.h | 2162 	2162 +	0 -	0 !
 2 files changed, 2186 insertions(+), 17099 deletions(-)

Comment 2

[Ben Newman (:bnewman) (:benjamn)]

Attachment: Combined patch created after 'make sync'-ing from validator.nu repo

Henri, you've already reviewed the changes to GenerateNamedCharactersCpp.java.  This patch regenerates the C++ files and adds a Makefile target (make named_characters) to be run within parser/html/java/translator.

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 395235 [details] [diff] [review]
Combined patch created after 'make sync'-ing from validator.nu repo

Looks good. (I didn't try compiling it.)

Comment 4

[Ben Newman (:bnewman) (:benjamn)]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/0fb9c41b5d87