505609 - [mozmill] Test for checking the Unknown Issuer error page appears

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

This is a placeholder bug for creating a test script for https://litmus.mozilla.org/show_test.cgi?id=6871 - Confirm Explanatory Text for Secure Connection Failed (Unknown Issuer)

Comment 1

[u279076]

Attachment: Initial patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 389833 [details] [diff] [review]
Initial patch

>+ * for the specific language governing rights and limitations under the
>+ * License.
>+ *
>+ * The Initial Developer of the Original Code is Mozilla Corporation.
>+ * Portions created by the Initial Developer are Copyright (C) 2009
>+ * the Initial Developer. All Rights Reserved.

As in the other test the license text misses the Mozmill Code part.

>+var teardownModule = function(module) {
>+  UtilsAPI.closeAllTabs(controller);
>+}

This function is not needed.

>+  // Verify the link in Technical Details is correct
>+  var link = new elementslib.ID(controller.tabs.activeTab, "cert_domain_link");
>+  controller.waitForElement(link);
>+  controller.assertNode(link);

When you are using waitForElement we don't need an assertNode afterwards. waitForElement will already assert if the element is not present in the given time range.

>+  if (link.getNode().textContent != "secure.mur.at") {  
>+    throw "Site link is invalid!";
>+  }

Can you please use assertProperty?

>+  // Verify the error code is correct
>+  var text = new elementslib.ID(controller.tabs.activeTab, "technicalContentText");
>+  controller.waitForElement(text);
>+  controller.assertNode(text);

assertNode can also be removed here.


We could also check for "mur.at uses an invalid security certificate." We can use the available properties to build the string:

http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US/chrome/pipnss/pipnss.properties#343

Comment 3

[u279076]

Attachment: Rev1

Comment 4

[u279076]

I made all revisions except for the following:

> We could also check for "mur.at uses an invalid security certificate." We can
> use the available properties to build the string:
>
> http://mxr.mozilla.org/mozilla-central/source/security/manager/locales/en-US
> /chrome/pipnss/pipnss.properties#343

I didn't implement this as the error code is contained in the same element "technicalContentText".  I think checking for the error code, get me out of here button, add exception button, and reported domain suffices.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 391385 [details] [diff] [review]
Rev1

I only changed two small things. The UtilsAPI is not necessary and the waitForPageLoad should have a timeout of 2000ms.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Checked in as http://hg.mozilla.org/qa/mozmill-tests/rev/ade35576ee0b

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.