505640 - Linkify bug numbers when displaying bug summary at the top of a bug

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Jesse Ruderman]

Reed has a patch to linkify bug numbers that appear in bug summaries (when shown at the top of a bug report).  We've used it as a bugzilla.mozilla.org local customization (see bug 452933).  Does Bugzilla want this patch?

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 2

[Frédéric Buclin]

Comment on attachment 389858 [details] [diff] [review]
patch - v1

r=LpSolit

Comment 3

[Frédéric Buclin]

We are frozen for 3.4, and this is an enhancement bug.

Comment 4

[Max Kanat-Alexander]

Doesn't quoteUrls(bug.bug_id) make all bug links into links to *this* bug?

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> Doesn't quoteUrls(bug.bug_id) make all bug links into links to *this* bug?

It's what I used on bmo with Bugzilla v3.0, and it worked fine. It got lost when ES did the v3.0 --> v3.2 upgrade, sadly. I will look at the code and double-check, though.

Comment 6

[Frédéric Buclin]

(In reply to comment #4)
> Doesn't quoteUrls(bug.bug_id) make all bug links into links to *this* bug?

No. It makes "comment 434" to point to comment 434 of the current bug. If you don't specify it, and "comment 434" appears in the bug summary, it will point either to show_bug.cgi or process_bug.cgi, depending if you just edited the bug or not. So bug.bug_id is only useful to determine which bug you are referring to when specifying "comment foo" alone (instead of the full "bug foo comment bar" notation). So this is the correct fix.

Comment 7

[Reed Loden [:reed]]

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.160; previous revision: 1.159
done