505678 - Downloadable font feature is broken with Sun Studio compiler on Solaris

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ginn Chen]

#pragma pack(n) would not work for non-POD class (("POD" means "plain old data".) with Sun Studio compiler.
A struct, union, or class is not a POD-class if it has a base class, or a virtual function, or a user-written constructor or destructor, a member of reference type, or a data member of any type that is not a POD.

AutoSwap_PRUint16 has a user-written constructor.
Thus with Sun Studio compiler, sizeof(HeadTable) is 56 rather then 54.

Comment 1

[Ginn Chen]

Attachment: patch

For Sun Studio compiler, override operator = instead of using user-written constructor.

Comment 2

[Ginn Chen]

Attachment: patch

Oops, fix the typo.

Comment 3

[John Daggett (:jtd)]

Comment on attachment 389883 [details] [diff] [review]
patch

Bummer about having to stick #ifdef's like this, but yeah, looks fine.

Comment 4

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/55fd6820c596

Comment 5

[Ginn Chen]

Comment on attachment 389883 [details] [diff] [review]
patch

Asking approval for 1.9.1 branch.

Feature lost on Solaris platform.
No impact for non Sun Studio compiler.

Comment 6

[Samuel Sidler (old account; do not CC)]

Comment on attachment 389883 [details] [diff] [review]
patch

Not for 1.9.1.2.

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 389883 [details] [diff] [review]
patch

Approved for 1.9.1.3. a=NPOTB, aka ss

(Nit: Don't checkin the weird removing and adding of endif at the end of the file.)

Comment 8

[Ginn Chen]

The weird removing and adding of end if at the end of the file is generated by GNU diff.
It's necessary for add/remove the trailing new line.
The last line would not be changed when applying the patch.

Comment 9

[Ginn Chen]

Committed to 1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/616501025dcf

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ginn, can you verify please with the official sources that it's not broken anymore for Firefox 3.5.3? I don't have a Solaris box and cannot build. Thanks.

Comment 11

[Ginn Chen]

Verified with
Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.1.3pre) Gecko/20090824 Shiretoko/3.5.3pre

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Ginn. Given your build id you have it only verified on 1.9.1. So lets revert to resolved on trunk. It's not so critical to verify.