nsSSLIOLayerHelpers::Init must rv check calls to hashtable Init

RESOLVED INVALID

Status

()

Core
Security: PSM
RESOLVED INVALID
9 years ago
2 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-logic], URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpcom/ds/nsDoubleHashtable.h&rev=3.17&mark=99,103-104,330#99

psm isn't checking the rv from Init here, that's a bug. (but it's unlikely to
be the cause of this crash...)

I wonder if someone could possibly explain why there are so many statics.

If there's no good reason to use statics, then we could probably do away with dynamic allocation for those two objects....
(Assignee)

Comment 1

9 years ago
Created attachment 389895 [details] [diff] [review]
and fix its caller...
Assignee: kaie → timeless
Status: NEW → ASSIGNED
Attachment #389895 - Flags: review?(kaie)

Updated

8 years ago
Whiteboard: [psm-logic]

Comment 2

6 years ago
Comment on attachment 389895 [details] [diff] [review]
and fix its caller...

bitrot and too much distracting noise in this patch
Attachment #389895 - Flags: review?(kaie) → review-

Comment 3

6 years ago
adding brian and honza in case they want to work on this correctness cleanup

Comment 4

2 years ago
Bug 734847 made nsTHashtable infalliable by default (and AFAICT nsNSSIOLayer.(h|cpp) don't use fallible ones) + Bug 910989 got rid of nsTHashtable::Init(), so there's nothing to do here anymore.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.