Closed Bug 505726 Opened 11 years ago Closed 4 years ago

nsWifiMonitor::DoScan seems to leak wlan_library in all failure cases

Categories

(Core :: Networking, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file, 1 obsolete file)

542     HINSTANCE wlan_library = LoadLibrary("Wlanapi.dll");

there's no FreeLibrary call. I'm not going to mark each early return, because well, what's the point.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390142 - Flags: review?(doug.turner)
Comment on attachment 390142 [details] [diff] [review]
patch

e:/builds/slave/win32-unit/mozilla/netwerk/wifi/src/nsWifiScannerWin.cpp(708) : error C2065: 'wlan_library' : undeclared identifier
Attachment #390142 - Flags: review?(doug.turner) → review-
Attached patch scope...Splinter Review
Attachment #390142 - Attachment is obsolete: true
Attachment #390371 - Flags: review?(doug.turner)
Comment on attachment 390371 [details] [diff] [review]
scope...

thanks for the cleanup.  the patches doesn't apply.
Attachment #390371 - Flags: review?(dougt) → review-
this code has changed radically since filed..
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.