nsWifiMonitor::DoScan seems to leak wlan_library in all failure cases

RESOLVED INCOMPLETE

Status

()

Core
Networking
RESOLVED INCOMPLETE
9 years ago
2 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, mlk})

Trunk
x86
Windows XP
coverity, mlk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

2.42 KB, patch
dougt
: review-
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
542     HINSTANCE wlan_library = LoadLibrary("Wlanapi.dll");

there's no FreeLibrary call. I'm not going to mark each early return, because well, what's the point.
(Assignee)

Updated

9 years ago
(Assignee)

Comment 1

9 years ago
Created attachment 390142 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390142 - Flags: review?(doug.turner)

Comment 2

9 years ago
Comment on attachment 390142 [details] [diff] [review]
patch

e:/builds/slave/win32-unit/mozilla/netwerk/wifi/src/nsWifiScannerWin.cpp(708) : error C2065: 'wlan_library' : undeclared identifier
Attachment #390142 - Flags: review?(doug.turner) → review-
(Assignee)

Comment 3

9 years ago
Created attachment 390371 [details] [diff] [review]
scope...
Attachment #390142 - Attachment is obsolete: true
Attachment #390371 - Flags: review?(doug.turner)

Comment 4

8 years ago
Comment on attachment 390371 [details] [diff] [review]
scope...

thanks for the cleanup.  the patches doesn't apply.
Attachment #390371 - Flags: review?(dougt) → review-
this code has changed radically since filed..
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.