nsNSSComponent methods pass nsAutoString's as arguments by value

RESOLVED INVALID

Status

()

Core
Security: PSM
--
major
RESOLVED INVALID
9 years ago
5 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [psm-logic], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
line 174 --  NS_IMETHOD DownloadCRLDirectly(nsAutoString, nsAutoString) = 0; 

String should be passed by reference
(Assignee)

Updated

9 years ago
Summary: nsNSSComponent::DownloadCRLDirectly passes to 148 byte arguments by value → nsNSSComponent methods pass nsAutoString's as arguments by value
(Assignee)

Comment 2

9 years ago
Created attachment 390183 [details] [diff] [review]
patch
Assignee: kaie → timeless
Status: NEW → ASSIGNED
Attachment #390183 - Flags: review?(kaie)

Updated

8 years ago
Whiteboard: [psm-logic]

Comment 3

6 years ago
Comment on attachment 390183 [details] [diff] [review]
patch

bitrot
Attachment #390183 - Flags: review?(kaie) → review-
Created attachment 708204 [details] [diff] [review]
unbitrotted patch

Kaie - I'm trying to get more involved with PSM/NSS, and I thought unbitrotting this patch might be a good start. Do you have time to take a look at this? Thanks.
Attachment #390183 - Attachment is obsolete: true
Attachment #708204 - Flags: review?(kaie)
Looks like this was obviated by bug 867465.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Attachment #708204 - Flags: review?(kaie)
You need to log in before you can comment on or make changes to this bug.