Closed Bug 505823 Opened 11 years ago Closed 7 years ago
NSSComponent methods pass ns Auto String's as arguments by value
line 174 -- NS_IMETHOD DownloadCRLDirectly(nsAutoString, nsAutoString) = 0; String should be passed by reference
PSMContentDownloader::setCrlAutodownloadKey http://mxr.mozilla.org/mozilla-central/ident?i=setCrlAutodownloadKey nsNSSComponent::RemoveCrlFromList http://mxr.mozilla.org/mozilla-central/ident?i=nsNSSComponent::RemoveCrlFromList
Summary: nsNSSComponent::DownloadCRLDirectly passes to 148 byte arguments by value → nsNSSComponent methods pass nsAutoString's as arguments by value
Assignee: kaie → timeless
Status: NEW → ASSIGNED
Attachment #390183 - Flags: review?(kaie)
Comment on attachment 390183 [details] [diff] [review] patch bitrot
Attachment #390183 - Flags: review?(kaie) → review-
Kaie - I'm trying to get more involved with PSM/NSS, and I thought unbitrotting this patch might be a good start. Do you have time to take a look at this? Thanks.
Looks like this was obviated by bug 867465.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.