JS_GetStringChars( JS_ValueToString(...)..) is a bad pattern

RESOLVED FIXED

Status

--
critical
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({coverity, crash, testcase})

Trunk
coverity, crash, testcase

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
This pattern can crash, xpinstall is the only place which uses this variant. bug 505838 covers the JS_GetStringBytes variant.
(Assignee)

Updated

10 years ago
Keywords: testcase
(Assignee)

Comment 2

10 years ago
Created attachment 390286 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390286 - Flags: review?(dveditz)
Comment on attachment 390286 [details] [diff] [review]
patch

r=dveditz
Attachment #390286 - Flags: review?(dveditz) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/59b775aa5008
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.