Closed Bug 505839 Opened 16 years ago Closed 16 years ago

JS_GetStringChars( JS_ValueToString(...)..) is a bad pattern

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

(Keywords: coverity, crash, testcase)

Attachments

(1 file)

patch
2.40 KB, patch
dveditz
: review+
Details | Diff | Splinter Review
This pattern can crash, xpinstall is the only place which uses this variant. bug 505838 covers the JS_GetStringBytes variant.
Keywords: testcase
Attached patch patch — — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390286 - Flags: review?(dveditz)
Comment on attachment 390286 [details] [diff] [review] patch r=dveditz
Attachment #390286 - Flags: review?(dveditz) → review+
http://hg.mozilla.org/mozilla-central/rev/59b775aa5008
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: