505892 - malloc_init_hard does not unlock init_lock if MALLOC_VALIDATE and malloc_rtree_new fails

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[timeless]

5530 malloc_init_hard(void)
5541         malloc_mutex_lock(&init_lock);
5550                 malloc_mutex_unlock(&init_lock);
5552                 return (false);

6020                 malloc_mutex_unlock(&init_lock);
6022                 return (true);

6037                 malloc_mutex_unlock(&init_lock);
6039                 return (true);

6065         chunk_rtree = malloc_rtree_new((SIZEOF_PTR << 3) - opt_chunk_2pow);
6066         if (chunk_rtree == NULL)
6067                 return (true);

6093         malloc_mutex_unlock(&init_lock);
6095         return (false);
6096 }

Comment 1

[timeless]

Attachment: untested

Comment 2

[Mike Hommey [:glandium]]

This was fixed with RAII for locks in bug 1411084.