Closed Bug 505894 Opened 11 years ago Closed 10 years ago

nsTableRowGroupFrame::InitChildReflowState's null check of aReflowState.frame is futile because aReflowState.Init would crash

Categories

(Core :: Layout: Tables, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: bernd_mozilla)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, Whiteboard: [notacrash])

Attachments

(1 file)

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/tables/nsTableRowGroupFrame.cpp&mark=356,363&rev=3.409#348

319 nsTableRowGroupFrame::InitChildReflowState(nsPresContext&     aPresContext, 
327     if (aReflowState.frame) {
334   aReflowState.Init(&aPresContext, -1, -1, pCollapseBorder, &padding);

259  	nsHTMLReflowState::Init(nsPresContext* aPresContext,
268  	  mStylePosition = frame->GetStylePosition();
Assignee: nobody → bernd_mozilla
Whiteboard: [notacrash]
Attached patch patchSplinter Review
do_query does the same null check...
Attachment #428378 - Flags: review?
Attachment #428378 - Attachment is patch: true
Attachment #428378 - Flags: review? → review?(timeless)
Attachment #428378 - Flags: review?(timeless) → review+
http://hg.mozilla.org/mozilla-central/rev/76ff2857fdaf
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.