Closed
Bug 505894
Opened 15 years ago
Closed 14 years ago
nsTableRowGroupFrame::InitChildReflowState's null check of aReflowState.frame is futile because aReflowState.Init would crash
Categories
(Core :: Layout: Tables, enhancement)
Core
Layout: Tables
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: bernd_mozilla)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, Whiteboard: [notacrash])
Attachments
(1 file)
|
1.16 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/tables/nsTableRowGroupFrame.cpp&mark=356,363&rev=3.409#348 319 nsTableRowGroupFrame::InitChildReflowState(nsPresContext& aPresContext, 327 if (aReflowState.frame) { 334 aReflowState.Init(&aPresContext, -1, -1, pCollapseBorder, &padding); 259 nsHTMLReflowState::Init(nsPresContext* aPresContext, 268 mStylePosition = frame->GetStylePosition();
|
||
Updated•15 years ago
|
Whiteboard: [notacrash]
do_query does the same null check...
Attachment #428378 -
Flags: review?
Attachment #428378 -
Attachment is patch: true
Attachment #428378 -
Flags: review? → review?(timeless)
Attachment #428378 -
Flags: review?(timeless) → review+
http://hg.mozilla.org/mozilla-central/rev/76ff2857fdaf
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•