nsTableRowGroupFrame::InitChildReflowState's null check of aReflowState.frame is futile because aReflowState.Init would crash

RESOLVED FIXED

Status

()

Core
Layout: Tables
--
enhancement
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: timeless, Assigned: Bernd)

Tracking

({coverity})

Trunk
coverity
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [notacrash], URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/tables/nsTableRowGroupFrame.cpp&mark=356,363&rev=3.409#348

319 nsTableRowGroupFrame::InitChildReflowState(nsPresContext&     aPresContext, 
327     if (aReflowState.frame) {
334   aReflowState.Init(&aPresContext, -1, -1, pCollapseBorder, &padding);

259  	nsHTMLReflowState::Init(nsPresContext* aPresContext,
268  	  mStylePosition = frame->GetStylePosition();
(Assignee)

Updated

9 years ago
Assignee: nobody → bernd_mozilla

Updated

8 years ago
Whiteboard: [notacrash]
(Assignee)

Comment 1

8 years ago
Created attachment 428378 [details] [diff] [review]
patch

do_query does the same null check...
Attachment #428378 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #428378 - Attachment is patch: true
Attachment #428378 - Flags: review? → review?(timeless)
(Reporter)

Updated

8 years ago
Attachment #428378 - Flags: review?(timeless) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/76ff2857fdaf
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.