505912 - "ASSERTION: View is hidden but widget is visible!" changing visibility of flash

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: View is hidden but widget is visible!: '!visible', file /Users/jruderman/central/view/src/nsViewManager.cpp, line 746

Could this be a regression from the compositor phase 1 landing?  This changeset changed some of the code around the assertion:

changeset:  6d131711f67f
user:        Robert O'Callahan <[e-mail]>
date:        Wed Jul 22 12:45:00 2009 +1200
summary:     Bug 339548. Part 9: Create nsRootPresContext::UpdatePluginGeometry, and use it. Make nsObjectFrame manage its widget directly.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

In this case the view is hidden because we have a visiblity:hidden leaf frame, but the widget is visible because we're never hiding plugin widgets anymore.

Here we should just use the widget's visibility status to control everything. This is the future-proof solution as we rely on views less and less.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/41b7c900d87c