Closed
Bug 505946
Opened 16 years ago
Closed 16 years ago
Consider adding a border to the exception box on the missing/invalid certificate page
Categories
(Camino Graveyard :: Accessibility, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: phiw2, Assigned: phiw2)
References
()
Details
(Whiteboard: [camino-2.0])
Attachments
(2 files)
|
57.84 KB,
image/png
|
Details | |
|
886 bytes,
patch
|
alqahira
:
review+
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
it might look like this
We should add a 1px transparent border around the yellow-orange box warning about adding an exception.
Reasoning: a user who forces her own colors (*) will not get any highlighting on that box. In that situation, the transparent border will become visible (using the user set $color) and draw some more attention tot he contents of the box.
(*) Preferences > Appearance > Colors & Links : Always use...
(filed following an email exchange with Smokey)
|
Assignee | |
Comment 1•16 years ago
|
||
The only eventual drawback: the box shifts 1px to the left.
Attachment #390166 -
Flags: review?(alqahira)
Assignee: nobody → phiw
Comment on attachment 390166 [details] [diff] [review]
one line fix
I'm not going to miss that 1px; r=ardissone
Attachment #390166 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #390166 -
Flags: review?(alqahira)
Attachment #390166 -
Flags: review+
|
||
Updated•16 years ago
|
Attachment #390166 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
|
||
Comment 3•16 years ago
|
||
Comment on attachment 390166 [details] [diff] [review]
one line fix
sr=smorgan
Landed on cvs trunk and CAMINO_2_0_BRANCH.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
You need to log in
before you can comment on or make changes to this bug.
Description
•