505992 - "Thunderbird Spotlight Metadata" shows up in spotlight searches (OSX)

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Bob Lord]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090722 Shredder/3.0b4pre

On Mac OSX, the spotlight file indexing system picks up indexing files from Thunderbird, however they should be excluded from the search results by default.

Comment 1

[Bob Lord]

...Or the file "Kind" should be changed to "Thunderbird Mail Message".

Comment 2

[Ludovic Hirlimann [:Usul]]

Could this be the same issue as in bug 506028 ?

Comment 3

[Rain [:rain1] (inactive)]

No, this is separate and OS-specific.

Comment 4

[Mark Banner (:standard8)]

I don't think we'd block on this, especially if it was the last thing in the release. Still wanted though.

Comment 5

[Mark Banner (:standard8)]

Attachment: Proposed fix

However, the fix is simple so here is a patch for it.

Bryan: this changes what is listed in the Finder window when doing a spotlight search for the 'kind' of items (think file type on windows explorer), it changes it from "Thunderbird Spotlight Metadata" to "Thunderbird Mail Message". Although they aren't all mail messages exactly, I think it is the best we can do on the whole.

Humph: seeing as you implemented this originally, requesting your review as well to see what you think.

Comment 6

[David Humphrey (:humph)]

Comment on attachment 391553 [details] [diff] [review]
Proposed fix

This looks good to me, thanks for doing it.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 391553 [details] [diff] [review]
Proposed fix

looks good, thanks!

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/20c7bfa51c75