50603 - please add an id to the View -> Toolbars menupopup

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Rann Bar-On]

line 212-216 of navigatorOverlay.xul:
<menupopup>
  <menuitem value="&navbarCmd.label;" observes="cmd_viewnavbar"  />
  <menuitem value="&personalbarCmd.label;" observes="cmd_viewpersonaltoolbar" />
  <menuitem value="&taskbarCmd.label;" observes="cmd_viewtaskbar" />
</menupopup>

Please add an id to this menupopup so it can be used in dynamic overlays.

That is, change above lines to:
<menupopup id="view_toolbars_popup">
  <menuitem value="&navbarCmd.label;" observes="cmd_viewnavbar" />
  <menuitem value="&personalbarCmd.label;" observes="cmd_viewpersonaltoolbar" />
  <menuitem value="&taskbarCmd.label;" observes="cmd_viewtaskbar" />
</menupopup>

Minor change, wouldn't affect anything else and would be very much appreciated.
 Thanks.

Comment 1

[Matthew T (active 1999-2002)]

Not a design issue, --> XPApps GUI

Termite, don't forget to mark any bugs which this bug blocks.

Comment 2

[Rann Bar-On]

ben_goodger checked the fix in yesterday and didn't mark it fixed.  The change
was made, so marking FIXED.  Thanks Ben :)

Comment 3

[sairuh (rarely reading bugmail)]

over to jrgm (or claudius) to vrfy.

Comment 4

[John Morrison]

lxr is your friend:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&fi
le=navigatorOverlay.xul&root=/cvsroot&subdir=mozilla/xpfe/browser/resources/cont
ent&command=DIFF_FRAMESET&rev1=1.126&rev2=1.127

verified fixed.