Add rect emptiness check to imgContainer::ExtractCurrentFrame()

RESOLVED FIXED

Status

()

Core
ImageLib
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Ryo Kawaguchi, Assigned: Joe Drew (not getting mail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: 

imgContainer::ExtractCurrentFrame() does not check if the intersection of the current frame rect and the crop rect is empty of not. If the intersection happens to be empty, it causes an assertion error in imgFrame::Init().

Reproducible: Always
(Assignee)

Comment 1

9 years ago
Created attachment 390284 [details] [diff] [review]
add error handling

Vlad, is NS_ERROR_NOT_AVAILABLE appropriate for this?
Assignee: nobody → joe
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #390284 - Flags: review?(vladimir)
Comment on attachment 390284 [details] [diff] [review]
add error handling

I would call it NS_ERROR_INVALID_ARG or something, but w/e.
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/bdbfdabc77f7
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.