If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Core dump on sign in with outdated WeaveCrypto.so

RESOLVED FIXED

Status

Cloud Services
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Mardak, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
Gary reported that on 0.5pre3, there was a core dump when logging in when using a WeaveCrypto.so that was compatible with 0.5pre2.

This is probably somehow related to bug 505571 that adds the verify passphrase check and bug 505401 that provides the crypto function to do the check.

But the front-end code should be checking if the verifyPassphrase function exists in crypto before trying to call it.

Gary, if you still have the 0.5pre2 binary, could you try running this in the error console?

Components.utils.import("resource://weave/util.js"); "verifyPassphrasee" in Svc.Crypto

It should return false (make sure you're showing All messages)..
thunder's analysis for the situation is correct: checking for 'in' is actually useless because it checks for existence of the method in the XPT (compiled IDL) which says the method is indeed present, but when the .dylib/.so/.dll is actually loaded it isn't - giving us a core dump.

The best way to solve this without introducing a new interface is simply to ensure that any loaded libraries have these methods in them.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 2

8 years ago
We should at least get rid of the broken "verifyPassphrase" in Svc.Crypo check then.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
http://hg.mozilla.org/labs/weave/rev/e376c9964b33
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.