506104 - add a memoized getter for PluralForm.jsm inside DownloadUtils.jsm

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Nochum Sossonko [:Natch]]

Attachment: patch

Comment 2

[Nochum Sossonko [:Natch]]

Oh, and I'm not sure how useful this will be, after looking a bit more through the calling startup code, DownloadMonitoPanel.init, which is called in delayedStartup, calls updateStatus which calls DownloadUtils.getTimeLeft which calls convertTimeUnits which calls converTimeUnitsUnits which uses PluralForm. Maybe it's better for the code compilation though, dunno...

Comment 3

[Dietrich Ayala (:dietrich)]

delayedStartup() is called asynchronously from BrowserStartup(), which means that this change will allow the event queue to be processed before importing the module. currently the importation of this module blocks the event queue unnecessarily.

Comment 4

[Nochum Sossonko [:Natch]]

Not with bug 506099 :)

It's better like this anyhow, as my logic was faulty, it isn't called unless there's a pending download.

Comment 5

[Nochum Sossonko [:Natch]]

Attachment: patch

It's unnecessary to go through the scoping, this works just as well as long as it's in the global scope (which is the case here). See bug 506104.

Comment 6

[Nochum Sossonko [:Natch]]

Attachment: err, for real

I need automatic qrefresh...

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d743242a080a