Add a blocklist to the add-on validator

VERIFIED FIXED in 5.0.8

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: clouserw, Assigned: rjwalsh)

Tracking

unspecified
5.0.8

Details

(URL)

Attachments

(2 attachments, 5 obsolete attachments)

(Reporter)

Description

9 years ago
The spec says we need a blocklist so we should add one.  Just simple admin crud and an empty table to hold them for now will be fine.
(Assignee)

Comment 1

9 years ago
Created attachment 390347 [details] [diff] [review]
CRUD framework and test integration

Really basic stuff here - quick and dirty.  Let me know if we need to elaborate on this
Attachment #390347 - Flags: review?(clouserw)
(Assignee)

Comment 2

9 years ago
Created attachment 390356 [details] [diff] [review]
CRUD Framework (forgot to include model and view file)
Attachment #390347 - Attachment is obsolete: true
Attachment #390356 - Flags: review?(clouserw)
Attachment #390347 - Flags: review?(clouserw)
(Reporter)

Comment 3

9 years ago
Comment on attachment 390356 [details] [diff] [review]
CRUD Framework (forgot to include model and view file)

- the primary key has to be `id`
- you need a migration .sql
- your INSERT doesn't work because you need to specify the columns.
- the GUIDs need to be trim()'d before inserting them into the db
Attachment #390356 - Flags: review?(clouserw) → review-
(Assignee)

Comment 4

9 years ago
Created attachment 390359 [details] [diff] [review]
Fixes to previous patch
Attachment #390356 - Attachment is obsolete: true
Attachment #390359 - Flags: review?(clouserw)
(Assignee)

Comment 5

9 years ago
Created attachment 390364 [details] [diff] [review]
Fixes to previous patch
Attachment #390359 - Attachment is obsolete: true
Attachment #390364 - Flags: review?(clouserw)
Attachment #390359 - Flags: review?(clouserw)
(Reporter)

Comment 6

9 years ago
Comment on attachment 390364 [details] [diff] [review]
Fixes to previous patch

r+ after:

1) "UNIQUE KEY `guid` (`guid`)," the trailing comma there is a syntax error and won't work

2) 'GuidBlacklist' in the developers_controller needs to be 'BlacklistedGuid'
Attachment #390364 - Flags: review?(clouserw) → review+
(Assignee)

Comment 7

9 years ago
Created attachment 390369 [details] [diff] [review]
Patch for production push

Patch for the push to production
Attachment #390364 - Attachment is obsolete: true
(Reporter)

Updated

9 years ago
Attachment #390369 - Flags: review+
(Assignee)

Comment 8

9 years ago
Committed in r30310
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
I blocklisted "ohhai@fun.tld" via https://preview.addons.mozilla.org/en-US/admin/guids, and tried to upload a test add-on with that in its <em:id>ohhai@fun.tld</em:id>, and got the following screenshot, which I'll attach.
Created attachment 390389 [details]
Post-fix screenshot; WFM
(Reporter)

Comment 12

9 years ago
Created attachment 390400 [details] [diff] [review]
smaller patch
(Reporter)

Updated

9 years ago
Attachment #390369 - Attachment is obsolete: true
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.