506132 - write session data to disk less often in WinCE

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I'll take this. It's as simple as setting browser.sessionstore.interval to be higher.

Right now we set it to 10s. What should we do on CE?

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Made the default every 20 seconds for WinCE.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 391119 [details] [diff] [review]
Patch v0.1

Make it 60s maybe?  Though really what we should do is something like 20s while on power, 60s while on battery.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2 (for check-in)

(In reply to comment #3)
> (From update of attachment 391119 [details] [diff] [review])
> Make it 60s maybe?  Though really what we should do is something like 20s while
> on power, 60s while on battery.

Made it 60s. That's a bit high, but should probably be OK. When we get the power notification service I think it would be worth making session store like you suggest. I'll file a bug for that.

Comment 5

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

pushed http://hg.mozilla.org/mozilla-central/rev/5508f700cfcf

Comment 6

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

It's been brought to my attention by sdwilsh that I probably should have put a new #ifdef with the previous declaration of this pref (based on something mconnor apparently said) - should I fix that?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Yes, I think we should fix that for all the WinCE-specific prefs in that block (in a new bug).

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

filed bug 508386 for the prefs