506154 - [W-2.2.1] Recently Viewed Collections

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Justin Scott [:fligtar]]

The collection directory sidebar should have a grid of icons or a list of names representing recently viewed collections so users can easily get back to recent collections. This is available to both logged-in and logged-out users.

Please use localStorage for this feature. (the feature will not be available to browsers that do not support localStorage or have JS disabled)

Assigning to chowse for designs.

Comment 1

[Chris Howse [:chowse]]

Hi-fid mockup:
http://people.mozilla.com/~chowse/drop/collections/5.0.8/Collection_Listing_Recent_HiFid.png

Comment 2

[Justin Scott [:fligtar]]

I like the Recently Viewed section. My concern with changing the top box is that the overall stats page isn't planned and the browse my collections link is the same as the My Collections tab. So the only helpful link there is Create a Collection, which is what's there currently.

I think we'll eventually have something to replace that box with for collection owners, but right now I don't think the replacement box provides enough value to warrant it.

Comment 3

[Wil Clouser [:clouserw]]

I agree with Justin.  I'm not really sure why we're trying to replace browser history anyway, but that's another discussion I guess.

Comment 4

[Justin Scott [:fligtar]]

We can implement this with only the Recently Viewed portion of the mockup.

Comment 5

[Jeff Balogh (:jbalogh)]

Can we use localStorage for this?  It's supported in FF 3.5, Safari 4, and IE8.  This is not an essential piece, so I think it's ok to not show it in older browsers.

http://www.quirksmode.org/dom/html5.html#localstorage

Comment 6

[Justin Scott [:fligtar]]

As mentioned in the description, yes, please use localStorage.

Comment 7

[Jeff Balogh (:jbalogh)]

Oh right.  I usually ignore the words you write, I'll try to be better about that from now on.

Comment 8

[Wil Clouser [:clouserw]]

I was going to give this bug to someone else but fligtar said you really wanted to use localStorage

Comment 9

[Jeff Balogh (:jbalogh)]

Attachment: show recently viewed collections

Comment 10

[Justin Scott [:fligtar]]

I tested this out on your khan and it looks pretty cool. One comment is that the Recently Viewed box should also show in the sidebar of the directory and search results, not just on collection view pages.

Comment 11

[Justin Scott [:fligtar]]

Well, now it's not showing up at all, which leads me to believe you're messing with things! boooooo git

Comment 12

[Jeff Balogh (:jbalogh)]

Attachment: v2

Now showing on all collection detail, listing, and search pages.

Comment 13

[Jeff Balogh (:jbalogh)]

Attachment: v3

With all the necessary files this time.

Comment 14

[Wil Clouser [:clouserw]]

Comment on attachment 394414 [details] [diff] [review]
v3

Pretty close, I'm seeing some dupes though.  To reproduce:

1) Load collection A
2) Load collection B
3) Refresh collection A (b will show up)
4) Refresh collection B (collection A will show up twice)

Comment 15

[Wil Clouser [:clouserw]]

Attachment: screenshot

Comment 16

[Jeff Balogh (:jbalogh)]

Attachment: v4

Thanks for the catch.  It was broken due to a typo, but now it's way better.

Comment 17

[Jeff Balogh (:jbalogh)]

Attachment: v4, for real

Of course, it helps to check in changes before cutting a new patch.

Comment 18

[Wil Clouser [:clouserw]]

Comment on attachment 394527 [details] [diff] [review]
v4, for real

Works in FF.  Let's double check it doesn't break other browsers.

Comment 19

[Jeff Balogh (:jbalogh)]

I played with it (successfully!) in Safari4 and IE8.

Comment 20

[Jeff Balogh (:jbalogh)]

r49377

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Firefox 3.5.2, Namoroka, IE 8, and Safari 4.0.3 (works).

Also regression-tested using Firefox 2.0.0.20, Opera 9.64, and Google Chrome (doesn't work, but no regressions found).