506183 - Static scrollbar on right side of license pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load https://preview.addons.mozilla.org/en-US/firefox/versions/license/67938
2. Look at the scrollbar on the right

Expected Results:

No static scrollbar

Actual Results:

Scrollbar (see screenshot)

Comment 1

[Milos Dinic [:Milos]]

I can patch it, but I`ll need to use max-height again, `cos there`s an __overflow-y__ property now. Just for a reminder, max-height doesn`t work in IE6 and IE7, but if that is biggie, then we could add separate property(new one) to fix it for IE browsers

Comment 2

[Fred Wenzel [:wenzel]]

do we want a scrollbar at all (i.e., do we need overflow-y)? If we don't care how long the page is, we should remove that altogther. If we do care, we should indeed add max-height.

That it will render differently on IE is not a problem, as long as it does not look broken, Milos.

Comment 3

[Milos Dinic [:Milos]]

We should hear from clouserw on this matter, I think. But now I have took a closer look, and my previous comment does not work. We got both overflow-y and max-heoght properties, and i forgot that __overflow__ will always show scrollbar, but it will be disabled if content does not overflow the max-height(in our case).

Comment 4

[Milos Dinic [:Milos]]

We could try with overflow-y: auto;

I think that could help, but I`m not sure how will that work with other elements using this class.

Comment 5

[Milos Dinic [:Milos]]

Attachment: patch v1

Here`s a patch that works for me.

Comment 6

[Fred Wenzel [:wenzel]]

Comment on attachment 390440 [details] [diff] [review]
patch v1

That looks good for me. I can commit it for you.

Comment 7

[Milos Dinic [:Milos]]

Wenzel, then please do, so we could try this immediately.

Comment 8

[Fred Wenzel [:wenzel]]

r30331. Thanks for fixing this, Milos!

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED in Firefox 3.5.1; looks great using IE 7 and 8, too.

Milos, thanks again!