Closed
Bug 506243
Opened 15 years ago
Closed 15 years ago
eliminate GC thread-local lists pools
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: igor, Assigned: igor)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
15.69 KB,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
Pooling of thread-local GC free-lists was added in bug 378918 to workaround bugs with thread-sharing between different domains. With runtime-private JSThread this is no longer an issue and free list pools just adds complexity to the GC. We should remove this.
Flags: wanted1.9.2?
|
Assignee | |
Comment 1•15 years ago
|
||
The patch effectively reverts the essence of thread-local free lists allocation to the state that was before bug 378918.
Attachment #390500 -
Flags: review?(brendan)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 390500 [details] [diff] [review] v1 >@@ -1938,35 +1861,29 @@ NewGCThing(JSContext *cx, uintN flags) ... >+ if (rt->gcMallocBytes >= rt->gcMaxMallocBytes || freeList) Transpose these || terms as the freeList non-null condition will be more likely true. >@@ -2014,25 +1931,19 @@ testReservedObjects: ... >+ if (rt->gcMallocBytes >= rt->gcMaxMallocBytes || freeList) Ditto. r=me with that. /be
Attachment #390500 -
Flags: review?(brendan) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
landed with nits addressed - http://hg.mozilla.org/tracemonkey/rev/44ec2dd12fd2
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/44ec2dd12fd2
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Flags: wanted1.9.2?
You need to log in
before you can comment on or make changes to this bug.
Description
•