506253 - GetNativeRegExp's use of u.code/u.func confuses coverity

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, enhancement)

Description

[timeless]

I'm just noting this, Coverity 4.2 can't see that code and func are related here:

3200     union { NIns *code; NativeRegExp func; } u;
3201     u.code = fragment->code();
3202     return u.func;

I know unions are fun, but I'm wondering if a cast might be more appropriate.

Comment 1

[Brendan Eich [:brendan]]

No, a cast is wrong and violates strict aliasing analysis. Coverity needs a fix. Please file a bug with them if you can, link to it here.

/be

Comment 2

[Jeff Walden [:Waldo]]

Does it complain about the same construct in js_ExecuteTree?  Probably so, but if it doesn't there may be a safe workaround available...

Comment 3

[timeless]

it complains about it a lot, i used this single url to FALSE all of the subsequent items, and yes, i intend to file a report (i have the contact, just not the focus, someone could bug me about reporting it...)

Comment 4

[Luke Wagner [:luke]]

Code was removed.