506304 - Wrong context menu position and dynamic hovering with windowless flash inside iframe

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Martijn Wargers (dead)]

Attachment: flash file needed for testcase

See upcoming testcase:
Right clicking on the flash embed, should give the context menu popup on the right position
Also, hovering over the flash embed, should make the blue circle red

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

A regression from the compositor landing, I presume?

Comment 5

[Martijn Wargers (dead)]

Yes, that's what I was thinking, hence the blocking bug 352093, although, I haven't looked for the regression range.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: easy fix

We just need to walk all the way up the view tree until we find a widget. GetNearestWidget is the easy way to do that.

This code is quite dodgy in the !aWindowless case, but I don't want to clean it up more than necessary to fix this regression.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: test code

Writing an automated test for this is quite a chore, since we have to add support for dispatching synthesized mouse events to windowless plugins on all platforms, and add API to the test plugin to retrieve mouse event coordinates, again on all platforms. Nevertheless, here it is!

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 391024 [details] [diff] [review]
easy fix

So this is really meant to be the offset from the parent widget, not from the document?  In that case, makes sense.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in the actual fix:
http://hg.mozilla.org/mozilla-central/rev/333fb0fdfd67
but I want to leave this open for the test code.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in test patch.

http://hg.mozilla.org/mozilla-central/rev/22588ab14ac6

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)