506320 - Plus sign for plugin add-ons returns 404 Error

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Tanner M. Young [:tmyoung]]

When loading https://addons.mozilla.org/en-US/firefox/browse/type:7 The plus sign is missing.

When I load the URL for the gif file, it returns a file not found message with a 404 Error code.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Here, look at the vertical | separator -- the "+" sign should be to the left of that.

Comment 2

[Milos Dinic [:Milos]]

It tries to pull remora/site/img/amo2009/icons/buttons/plus-green-8x9.gif instead of /img/amo2009/icons/buttons/plus-green-8x9.gif

Comment 3

[Milos Dinic [:Milos]]

Attachment: patch v1

Showing the love :)

Comment 4

[Milos Dinic [:Milos]]

Thanks to :mzz for helping me to find which file to edit.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 390670 [details] [diff] [review]
patch v1

I agree it's broken, but the right way to do this would be to use the $html->img() so it will still work for people with different paths.

Comment 6

[Fred Wenzel [:wenzel]]

Check out

http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/addons/display.thtml?view=markup&pathrev=30302

line 213 for an example of what Wil is referring to.

Comment 7

[Milos Dinic [:Milos]]

So, you want me to use <img src="<?=$html->urlImage('amo2009/icons/buttons/plus-green-8x9.gif')?>" instead of <img src="/img/amo2009/icons/buttons/plus-green-8x9.gif" ?

Comment 8

[Fred Wenzel [:wenzel]]

Yes.

Comment 9

[Milos Dinic [:Milos]]

Attachment: patch v2

Done.

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 391338 [details] [diff] [review]
patch v2

Yup, that works. Need me to check that in for you?

Comment 11

[Milos Dinic [:Milos]]

(In reply to comment #10)
> (From update of attachment 391338 [details] [diff] [review])
> Yup, that works. Need me to check that in for you?

Yes please. I don`t have an svn commit privileges on AMO.

Comment 12

[Fred Wenzel [:wenzel]]

r48049. Thanks!

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/browse/type:7; I tested IE 7/8, Firefox 3.5.1, and it looks good.

Thanks, Milos!