Plus sign for plugin add-ons returns 404 Error

VERIFIED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: tmyoung, Assigned: Milos)

Tracking

Details

(Whiteboard: [AMO508Testday], URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
When loading https://addons.mozilla.org/en-US/firefox/browse/type:7 The plus sign is missing.

When I load the URL for the gif file, it returns a file not found message with a 404 Error code.
(Reporter)

Updated

8 years ago
Whiteboard: [AMO508Testday]
(Reporter)

Updated

8 years ago
Severity: major → normal
Created attachment 390508 [details]
Screenshot

Here, look at the vertical | separator -- the "+" sign should be to the left of that.
(Assignee)

Comment 2

8 years ago
It tries to pull remora/site/img/amo2009/icons/buttons/plus-green-8x9.gif instead of /img/amo2009/icons/buttons/plus-green-8x9.gif
(Assignee)

Updated

8 years ago
Assignee: nobody → bmo
Status: NEW → ASSIGNED
(Assignee)

Comment 3

8 years ago
Created attachment 390670 [details] [diff] [review]
patch v1

Showing the love :)
Attachment #390670 - Flags: review?(clouserw)
(Assignee)

Comment 4

8 years ago
Thanks to :mzz for helping me to find which file to edit.
Attachment #390670 - Flags: review?(clouserw) → review-
Comment on attachment 390670 [details] [diff] [review]
patch v1

I agree it's broken, but the right way to do this would be to use the $html->img() so it will still work for people with different paths.
Check out

http://viewvc.svn.mozilla.org/vc/addons/trunk/site/app/views/addons/display.thtml?view=markup&pathrev=30302

line 213 for an example of what Wil is referring to.
(Assignee)

Comment 7

8 years ago
So, you want me to use <img src="<?=$html->urlImage('amo2009/icons/buttons/plus-green-8x9.gif')?>" instead of <img src="/img/amo2009/icons/buttons/plus-green-8x9.gif" ?
Yes.
(Assignee)

Comment 9

8 years ago
Created attachment 391338 [details] [diff] [review]
patch v2

Done.
Attachment #390670 - Attachment is obsolete: true
Attachment #391338 - Flags: review?(fwenzel)
Comment on attachment 391338 [details] [diff] [review]
patch v2

Yup, that works. Need me to check that in for you?
Attachment #391338 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 11

8 years ago
(In reply to comment #10)
> (From update of attachment 391338 [details] [diff] [review])
> Yup, that works. Need me to check that in for you?

Yes please. I don`t have an svn commit privileges on AMO.
r48049. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: push-needed
Resolution: --- → FIXED
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/browse/type:7; I tested IE 7/8, Firefox 3.5.1, and it looks good.

Thanks, Milos!
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.