506371 - Learnmore and thumbnail links returned in the API on preview point to production, instead

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: API, defect, P5)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Learnmore and thumbnail links returned in the API on preview point to production, instead

Sorry; don't know if this is a regression or not.

Following clouserw's steps to reproduce / verify https://bugzilla.mozilla.org/show_bug.cgi?id=506030#c5, we found that that the links to add-ons returned in the API are hardcoded to production.

STR:

1. Load https://preview.addons.mozilla.org/en-US/firefox/api/search/firebug/all/10/
2. Look at the learnmore/thumbnail links

Expected Results:

I would think that they would point to preview.*

Actual Results:

Add-on links are hardcoded to prod

Comment 1

[Wil Clouser [:clouserw]]

Attachment: don't hardcode

This patches changes it to use SITE_URL.  It looks like the last time that line was changed was to go from services.addons.mozilla.org -> addons.mozilla.org.  I don't remember that and the commit message doesn't have a bug in it.  morgamic did it so I'm hoping he remembers.  r?morgamic

Comment 2

[Michael Morgan [:morgamic]]

Comment on attachment 390581 [details] [diff] [review]
don't hardcode

That's what it's there for. :)

Comment 3

[Michael Morgan [:morgamic]]

Looks like this is related to bug 434603 -- last time this was done the images broke in the add-on manager so it's important we QA it. See the other bug for a backstory -- this is actually sort of a dupe.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> Looks like this is related to bug 434603 -- last time this was done the images
> broke in the add-on manager so it's important we QA it. See the other bug for a
> backstory -- this is actually sort of a dupe.

So is this going to land in 5.0.8 with a chance for us to test?

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> (In reply to comment #3)
> > Looks like this is related to bug 434603 -- last time this was done the images
> > broke in the add-on manager so it's important we QA it. See the other bug for a
> > backstory -- this is actually sort of a dupe.
> 
> So is this going to land in 5.0.8 with a chance for us to test?

Nope, this is dependent on bug 434603, and we should fix it right so that bug might be dependent on bug 482837

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 390581 [details] [diff] [review]
don't hardcode

Yes please.

Comment 7

[Wil Clouser [:clouserw]]

Depends on bugs that aren't in 5.1 so this shouldn't be in 5.1 either.

Comment 8

[Wil Clouser [:clouserw]]

Thanks for filing this.  In an effort to not drown in existing reports we're aggressively closing old enhancements and bugs to get the buglist to a reasonable level so we can scope and process bug sprints in an effective manner.

Patches for this bug are still welcome.