506437 - The titlebar of a tear off window is not updated correctly after having detached a tab with private browsing mode

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2pre) Gecko/20090724 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2pre) Gecko/20090724 Firefox/3.5.1

The titlebar of a tear off window is not updated correctly after having detached a tab.
Only an application name is displayed, and the title of contents is not included.

Reproducible: Always

Steps to Reproduce:
1.Start Minefield with new profile
2.Start Private Browsing (Ctrl+Ship+P)
3.Open 2 or more tabs
4.Detach a tab by drag & drop. (OR select "Open in a New Window" in the tab context)
Actual Results:  
The titlebar is displayed as "Minefiled (Private Browsing)"

Expected Results:  
The titlebar should be displayed as "foobar - Minefiled (Private Browsing)"

This problem happens only with a private browsing mode,

Comment 1

[Alice0775 White]

This problem happens also on 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2pre) Gecko/20090724 Firefox/3.5.2pre ID:20090724042626

Comment 2

[Alice0775 White]

In Comment #0
UA was wrong; is as follows definitely.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090724 Minefield/3.6a1pre ID:20090724045715

Comment 3

[(no longer active)]

Confirming.

CCing Mano and Dao to see if they have any idea what the problem is here.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

I rewrote the test to make it more readable and also cover more cases.  For each case, the test covers the window title both for normal and detached tabs.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9f2da1d06ab5

Comment 6

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.2 branch using  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1pre) Gecko/20091001 Namoroka/3.6b1pre. Adding keyword.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 392953 [details] [diff] [review]
Patch (v1)

Thanks for including the test, but we don't need to fix minor polish bugs on the security/stability branches. a1.9.1.5-minus

Comment 8

[Daniel Veditz [:dveditz]]

fixed for 1.9.1 in bug 513420 (required by test-case fix)

Comment 9

[(no longer active)]

The fix for this bug landed on 1.9.1 as part of the fix for bug 513420.