506524 - Disable Necko-WiFi by default on OS/2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Peter Weilbacher]

Attachment: do the change

Currently, we have to add --disable-necko-wifi by default on OS/2 so that the build completes. I think the comments on the newsgroup said that we should not the implementation a priority, so we should instead make --disable-necko-wifi the default on OS/2 (at least for the moment).

The attached patch seems to work. I guess we could also add an "echo" line to remind us with every build that something is missing on OS/2.

Comment 1

[Walter Meinl]

Comment on attachment 390710 [details] [diff] [review]
do the change


>I think the comments on the newsgroup said that we should not
> the implementation a priority, so we should instead make --disable-necko-wifi
> the default on OS/2 (at least for the moment).
> 
> The attached patch seems to work. I guess we could also add an "echo" line to
> remind us with every build that something is missing on OS/2.
I agree, that we need a reminder, but at configure time it might be annoying after some time, if we don't find a volunteer to write that code. I would suggest to add a comment in configure referring to this bug here, of which the title should be changed to sth. like Handle wifi-necko on OS/2 and to change the description of the patch to "disable necko-wifi for the moment" or to file a follow-up bug and refer in the configure comment to that bug #

Comment 2

[Peter Weilbacher]

Done as suggested:
http://hg.mozilla.org/mozilla-central/rev/1450e521833b