506631 - nsSAXXMLReader should not use nsDependentString(PRUnichar(0))

Status: RESOLVED WONTFIX

(Core :: XML, defect)

Description

[timeless]

192 nsSAXXMLReader::HandleStartDTD(const PRUnichar *aName,
193                                const PRUnichar *aSystemId,
194                                const PRUnichar *aPublicId)
195 {
196   PRUnichar nullChar = PRUnichar(0);
197   if (!aName)
198     aName = &nullChar;
199   if (!aSystemId)
200     aSystemId = &nullChar;
201   if (!aPublicId)
202     aPublicId = &nullChar;
203 
204   mSystemId = aSystemId;
205   mPublicId = aPublicId;
206   if (mLexicalHandler) {
207     return mLexicalHandler->StartDTD(nsDependentString(aName),
208                                      nsDependentString(aSystemId),
209                                      nsDependentString(aPublicId));

Comment 1

[timeless]

Attachment: patch

Comment 2

[timeless]

Attachment: for the class

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why? The sting code seems to deal fine:

http://mxr.mozilla.org/mozilla-central/source/xpcom/build/nsXPCOMStrings.cpp#219

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 390798 [details] [diff] [review]
for the class

Removing review request while waiting for reply.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:peterv, could you have a look please?
For more information, please visit auto_nag documentation.