Open Bug 506631 Opened 11 years ago Updated 2 years ago

nsSAXXMLReader should not use nsDependentString(PRUnichar(0))

Categories

(Core :: XML, defect, critical)

defect
Not set
critical

Tracking

()

ASSIGNED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

192 nsSAXXMLReader::HandleStartDTD(const PRUnichar *aName,
193                                const PRUnichar *aSystemId,
194                                const PRUnichar *aPublicId)
195 {
196   PRUnichar nullChar = PRUnichar(0);
197   if (!aName)
198     aName = &nullChar;
199   if (!aSystemId)
200     aSystemId = &nullChar;
201   if (!aPublicId)
202     aPublicId = &nullChar;
203 
204   mSystemId = aSystemId;
205   mPublicId = aPublicId;
206   if (mLexicalHandler) {
207     return mLexicalHandler->StartDTD(nsDependentString(aName),
208                                      nsDependentString(aSystemId),
209                                      nsDependentString(aPublicId));
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #390796 - Flags: review?(jonas)
Summary: nsSAXXMLReader::HandleStartDTD should use EmptyString → nsSAXXMLReader should not use nsDependentString(PRUnichar(0))
Attached patch for the classSplinter Review
Attachment #390796 - Attachment is obsolete: true
Attachment #390798 - Flags: review?(jonas)
Attachment #390796 - Flags: review?(jonas)
Comment on attachment 390798 [details] [diff] [review]
for the class

Removing review request while waiting for reply.
You need to log in before you can comment on or make changes to this bug.