506633 - Options appearance looks different from Firefox on Vista

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: firefox Options appearance

The current Options window looks different from Firefox. We should aim at a more flatter appearance.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch on trunk

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of the patch in action

Comment 3

[Magnus Melin [:mkmelin]]

Andreas, please flag patches you think are ready for review as such, so things move along.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 390800 [details] [diff] [review]
patch on trunk

I like the change but I'm unsure about the actual code.  Part of me thinks we should be doing a #include of the other preferences.css so we don't repeat all the selectors.

I'll let magnus decide what's best.

Also, give yourself contributor credit and remove scott. :)

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

Lets see if this works.

Comment 7

[Andreas Nilsson (:andreasn)]

Attachment: the right patch

err..._this_ is the updated patch, selected the patch I had just downloaded in another folder. Oh hierarchical filesystem, my old enemy, we meet again!

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 393158 [details] [diff] [review]
the right patch

Sorry, i was too slow so this bitrotted some :(

>+# The Original Code is the Firefox Preferences System.
>+#
>+# The Initial Developer of the Original Code is
>+# Scott MacGregor.
>+# Portions created by the Initial Developer are Copyright (C) 2005
>+# the Initial Developer. All Rights Reserved.
>+#
>+# Contributor(s):
>+#   Andreas Nilsson <[e-mail]>

Did you actually copy the code form somewhere? mxr says no? You can make it 

The Original Code is mozilla.org code.

... and make youreself the initial developer if you are. (I don't think vague inspiration from someone elses code makes them the original author.) Fix the year as well if so.

>+# ***** END LICENSE BLOCK *****
>+*/
>+
>+%include messenger.css

Shouldn't this be preferences.css?

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: updated patch

andreas: I had some time to update this patch tonight so here's a new version to work with; unbitrotted and fixed a few pieces that didn't seem to work for me.  I believe all that is left from here would be to fix up the license to correctly point to you.  Resubmit for review and you're done.

Comment 10

[Andreas Nilsson (:andreasn)]

Attachment: updated patch fixing the copyright info

After some discussion with Standard8 on IRC, I put Mozilla Messaging as the initial developer and myself as contributor.

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 395289 [details] [diff] [review]
updated patch fixing the copyright info

r=mkmelin

Comment 12

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/dfe67096c8d8

Comment 13

[Tyler Downer [He/Him]]

V with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090826 Shredder/3.1a1pre