Closed Bug 506633 Opened 11 years ago Closed 11 years ago

Options appearance looks different from Firefox on Vista

Categories

(Thunderbird :: Preferences, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0b4

People

(Reporter: andreasn, Assigned: andreasn)

References

Details

Attachments

(3 files, 4 obsolete files)

The current Options window looks different from Firefox. We should aim at a more flatter appearance.
Attached patch patch on trunk (obsolete) — Splinter Review
Andreas, please flag patches you think are ready for review as such, so things move along.
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Blocks: 488060
Attachment #390800 - Flags: ui-review?(clarkbw)
Duplicate of this bug: 495534
Comment on attachment 390800 [details] [diff] [review]
patch on trunk

I like the change but I'm unsure about the actual code.  Part of me thinks we should be doing a #include of the other preferences.css so we don't repeat all the selectors.

I'll let magnus decide what's best.

Also, give yourself contributor credit and remove scott. :)
Attachment #390800 - Flags: ui-review?(clarkbw)
Attachment #390800 - Flags: ui-review+
Attachment #390800 - Flags: review?(mkmelin+mozilla)
Attached patch updated patch (obsolete) — Splinter Review
Lets see if this works.
Attachment #390800 - Attachment is obsolete: true
Attachment #390800 - Flags: review?(mkmelin+mozilla)
Attached patch the right patch (obsolete) — Splinter Review
err..._this_ is the updated patch, selected the patch I had just downloaded in another folder. Oh hierarchical filesystem, my old enemy, we meet again!
Attachment #393156 - Attachment is obsolete: true
Attachment #393158 - Flags: ui-review?(clarkbw)
Attachment #393158 - Flags: review?(mkmelin+mozilla)
Comment on attachment 393158 [details] [diff] [review]
the right patch

Sorry, i was too slow so this bitrotted some :(

>+# The Original Code is the Firefox Preferences System.
>+#
>+# The Initial Developer of the Original Code is
>+# Scott MacGregor.
>+# Portions created by the Initial Developer are Copyright (C) 2005
>+# the Initial Developer. All Rights Reserved.
>+#
>+# Contributor(s):
>+#   Andreas Nilsson <nisses.mail@home.se>

Did you actually copy the code form somewhere? mxr says no? You can make it 

The Original Code is mozilla.org code.

... and make youreself the initial developer if you are. (I don't think vague inspiration from someone elses code makes them the original author.) Fix the year as well if so.

>+# ***** END LICENSE BLOCK *****
>+*/
>+
>+%include messenger.css

Shouldn't this be preferences.css?
Attached patch updated patch (obsolete) — Splinter Review
andreas: I had some time to update this patch tonight so here's a new version to work with; unbitrotted and fixed a few pieces that didn't seem to work for me.  I believe all that is left from here would be to fix up the license to correctly point to you.  Resubmit for review and you're done.
Attachment #393158 - Attachment is obsolete: true
Attachment #393158 - Flags: ui-review?(clarkbw)
Attachment #393158 - Flags: review?(mkmelin+mozilla)
After some discussion with Standard8 on IRC, I put Mozilla Messaging as the initial developer and myself as contributor.
Attachment #395269 - Attachment is obsolete: true
Attachment #395289 - Flags: review?(mkmelin+mozilla)
Comment on attachment 395289 [details] [diff] [review]
updated patch fixing the copyright info

r=mkmelin
Attachment #395289 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/dfe67096c8d8
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
V with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090826 Shredder/3.1a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.