If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[MLK] Leaking many PRUnichar strings in nsBaseFilePicker::AppendFilters(PRInt32 aFilterMask)

VERIFIED FIXED in M18

Status

()

Core
XUL
P2
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Patrick C. Beard, Assigned: Brian Ryner (not reading))

Tracking

({mlk})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+], URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
The title and filter strings are being leaked repeatedly in the function pointed 
to by the URL above. Enclosing a patch that should fix the leak, as well as 
reduce the copying of strings by using NS_LITERAL_STRING().
(Reporter)

Updated

17 years ago
Keywords: mlk
(Reporter)

Comment 1

17 years ago
Created attachment 13684 [details] [diff] [review]
Patch to fix leaks.

Comment 2

17 years ago
->bryner, nsbeta3+, P2 for M18
Assignee: trudelle → bryner
Keywords: nsbeta3, patch
Priority: P3 → P2
Whiteboard: [nsbeta3+]
Target Milestone: --- → M18
(Assignee)

Comment 3

17 years ago
Checked in, thanks beard.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 4

17 years ago
verified that the patch is in version 1.7 in the tree. Marking as such.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.