Closed
Bug 506641
Opened 15 years ago
Closed 15 years ago
Click image resizing for nsImageDocument should be disabled
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
()
Details
Attachments
(2 files, 1 obsolete file)
954 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
3.89 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Go to the test url 2. Pan a little bit and release the mouse/finger Actual Result: The image is resized Expected result: The image is not resized
Assignee | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
I think we should be looking at the InputHandler code, as well, to see if we are the ones sending the "click" at the end of the pan.
Comment 3•15 years ago
|
||
OK, to clarify -- because we have our own zoom mechanism, we want to use that instead of the desktop "click-zoom" for loading single pictures. This should be fixed by avoiding sending click events to ImageDocuments.
Comment 4•15 years ago
|
||
Vivien, can you modify the CPP patch to only read the pref during the Init() call matching the current _PREF read and storing that in a local member? That's the only change I think it needs before pushing for core code review.
Comment 6•15 years ago
|
||
Comment on attachment 391080 [details] [diff] [review] cpp part V0.1.1 Boris, can you review the platform part of this patch? In Fennec we don't want to have any of the image click behavior or image scaling behavior.
Attachment #391080 -
Flags: review?(bzbarsky)
Updated•15 years ago
|
Attachment #390805 -
Flags: review+
Updated•15 years ago
|
Attachment #391080 -
Flags: review?(bzbarsky) → review+
Comment 7•15 years ago
|
||
m-c: https://hg.mozilla.org/mozilla-central/rev/77087580d570 m-b: https://hg.mozilla.org/mobile-browser/rev/74b006ed4d76
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 8•15 years ago
|
||
Verified fixed in the Maemo build form 8/11/2009.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → 21
You need to log in
before you can comment on or make changes to this bug.
Description
•