Closed Bug 506694 Opened 15 years ago Closed 14 years ago

[@ nsXPInstallManager::OnStopRequest] inconsistent handling of mItem

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

(Keywords: coverity, crash)

Crash Data

Attachments

(1 file)

patch
999 bytes, patch
dveditz
: review+
Details | Diff | Splinter Review 
1160 nsXPInstallManager::OnStopRequest(nsIRequest *request, nsISupports *ctxt,
1169             NS_ASSERTION( mItem->mOutStream, "XPIManager: output stream doesn't exist");
1185     NS_ASSERTION( mItem, "Bad state in XPIManager");
1186     if ( mItem && mItem->mOutStream )
1190     }
1196         if ( mItem->mFile )
Attached patch patch — — Splinter Review 
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #390922 -
        Flags: review?(dveditz)

    
    

    
  
Comment on attachment 390922 [details] [diff] [review]
patch

r=dveditz

        Attachment #390922 -
        Flags: review?(dveditz) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/93dc36a80f02
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsXPInstallManager::OnStopRequest]
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: