506796 - Produce debug-able optimized builds of NSPR for Mozilla on MacOSX

Status: REOPENED

(NSPR :: NSPR, defect)

Description

[glen beasley]

NSPR is now able to build special builds that are optimized but also have
debugging symbols.  This is presently enabled by setting the environment 
variable MOZ_DEBUG_SYMBOLS to a non-empty string.  But presently this 
only works on Windows, and then only when built with MSVC.  

This bug requests that it also be made to work with Mac OS X builds.

Comment 1

[glen beasley]

Attachment: create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

tested for 32 and 64 bit builds.

Comment 2

[Wan-Teh Chang]

Comment on attachment 390955 [details] [diff] [review]
create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

Glen, please try adding the flags to the CFLAGS variable instead.  Thanks!

Comment 3

[(not currently active) Ted Mielczarek]

For Firefox builds, we simply export CFLAGS/CXXFLAGS to contain -gdwarf-2, and NSPR respects that, as wtc indicates.

Comment 4

[glen beasley]

marking bug as invalid. NSPR already imports CFLAGS on MAC OS X 

see: configure.in
*-darwin*)
    AC_DEFINE(XP_UNIX)
    AC_DEFINE(DARWIN)
    AC_DEFINE(HAVE_BSD_FLOCK)
    AC_DEFINE(HAVE_SOCKLEN_T)
    AS='$(CC) -x assembler-with-cpp'
    CFLAGS="$CFLAGS -Wall -fno-common"


note, while I could test a build of firefox then I could see the import of the configured CFLAGS done correctly, when I tried to build nspr by itself, with first setting export CFLAGS="-gdwarf-2 -gfull" in the terminal, then building NSPR I was not able to get my settings imported.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Wait, if the definition of this task was purely "make this work in Firefox
builds", then perhaps nothing more needs to be done.  

But I want to have a single method that cause both NSS and NSPR to be 
built this way.  I want to be able to define a single environment variable
and be assured that the optimized builds of both NSS and NSPR will have 
symbols.  

Is that now the case?  If so, then this can be resolved WORKSFORME. 
Otherwise ...

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.