506804 - libnssutil3.so and libnssdbm3.so contain no version string.

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

libnssutil3.so and libnssdbm3.so contain no version string:
$ ident libnssutil3.so  | grep Header
$ ident libnssdbm3.so  | grep Header
$ ident libnss3.so | grep NSS
     $Header: NSS 3.12.3.1 (debug)  Jul 27 2009 16:45:46 $

This is because we don't have any .c files in
mozilla/security/nss/lib/util and mozilla/security/nss/lib/softoken/legacydb
that reference the version strings.  Here is an example of
how we do that in mozilla/security/nss/lib/ssl:
http://mxr.mozilla.org/security/ident?i=__nss_ssl_rcsid

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Changing libnssdbm3 will affect FIPS code, I'm afraid

Comment 2

[Wan-Teh Chang]

Attachment: Add version string to libnssutil3.so (checked in)

libnssutil3.so doesn't have a GetVersion or VersionCheck function,
so I added the magic volatile variable to SECOID_Init, the only
xxx_Init function in libnssutil3.so.

Comment 3

[Wan-Teh Chang]

Attachment: Add version string to libnssdbm3.so (for SOFTOKEN_3_13_BRANCH; checked in)

Comment 4

[Elio Maldonado]

Comment on attachment 426127 [details] [diff] [review]
Add version string to libnssdbm3.so (for SOFTOKEN_3_13_BRANCH; checked in)

r+ for the 3.13 branch.

Comment 5

[Elio Maldonado]

I look forward to the day when we can decouple database management from softoken.

Comment 6

[Wan-Teh Chang]

Comment on attachment 426122 [details] [diff] [review]
Add version string to libnssutil3.so (checked in)

I checked in this patch on the NSS trunk (NSS 3.12.6).

Checking in secoid.c;
/cvsroot/mozilla/security/nss/lib/util/secoid.c,v  <--  secoid.c
new revision: 1.55; previous revision: 1.54
done

Comment 7

[Wan-Teh Chang]

Comment on attachment 426127 [details] [diff] [review]
Add version string to libnssdbm3.so (for SOFTOKEN_3_13_BRANCH; checked in)

I checked in this patch on the SOFTOKEN_3_13_BRANCH (NSS 3.13).

Checking in lginit.c;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/lginit.c,v  <--  lginit.c
new revision: 1.14.8.2; previous revision: 1.14.8.1
done