506849 - Omnibus ad-blocking bug for August 2009

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This bug brought to you by these fine sponsors:

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Sam's already complaining about ads on bing:

http://www.bing.com/search?q=mac&go=&form=QBLH&qs=n
http://www.bing.com/search?q=london&go=&form=QBLH&qs=n

div[class="sb_adsW"] for the top/bottom
div[class="sb_adsN"] for the sidebar

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Apparently the latest update breaks collegehumor.com.  

Turns out it's that div[class^="ad_"] that I was worried about (bug 503745 comment 3); it looks like most of the page, and all of the content, is inside <div id="skin" class="ad_redirect_container">.

Comment 3

[philippe (part-time)]

On http://www.sanspo.com/ (popular Jpn sportsnewspaper site)

banner ad on individual articles: div class="adwide"
sidebar ads: div class="module adimg"
and G. : div class="adgoogle"

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fixes

Short, sweet, and to the point, fixes these and bug 513109.

I had to change the sb_adsW rule to use ~ because the bottom block now has two classes; otherwise everything is as previously mentioned.

Comment 5

[Stuart Morgan]

Comment on attachment 397495 [details] [diff] [review]
Fixes

sr=smorgan

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on CVS trunk and CAMINO_2_0_BRANCH.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on MOZILLA_1_8_BRANCH in advance of Camino 1.6.10.