Closed Bug 506887 Opened 11 years ago Closed 10 years ago

In js/src, --with-nspr-prefix doesn't seem to be implemented

Categories

(Firefox Build System :: General, defect)

Other Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorendorff, Assigned: jimb)

Details

Attachments

(1 file)

--with-nspr-prefix is very nicely documented in `configure --help` and at:
  https://developer.mozilla.org/en/SpiderMonkey/JSAPI_Reference/JS_THREADSAFE

But it doesn't seem to do anything, and I don't see any mentions of nspr-prefix in js/src/configure.in.
--with-system-nspr... please fix the docs, since we rely on that name matching the name in the mozilla configure.
Oh, I misread. What would the prefix do? Look for a pkgconfig or nspr-config file?
Assignee: nobody → jim
The configure code to handle --with-nspr-prefix comes from js/src/build/autoconf/nspr.m4.  Now, does it do anything...
Ideally, we'd go into build/autoconf/nspr.m4 and fix the documentation
for --with-nspr-prefix and --with-nspr-exec-prefix, but that file is
supposed to remain identical with the copy from NSPR itself, and
the --with-system-nspr flag isn't present in all contexts in which that
file is used.
Attachment #391164 - Flags: review?(ted.mielczarek)
Attachment #391164 - Flags: review?(ted.mielczarek) → review+
Whiteboard: checkin
Whiteboard: checkin → [checkin-needed]
http://hg.mozilla.org/mozilla-central/rev/a25abd332043
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.