506901 - preference advanced pane not updated on init

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

http://mxr.mozilla.org/mozilla1.9.1/source/browser/components/preferences/advanced.js#43

The pref "browser.preferences.advanced.selectedTabIndex" is unset with a fresh profile and therefore the init() function is left without doing the UI update stuff below:

64 #ifdef MOZ_UPDATER
65     this.updateAppUpdateItems();
66     this.updateAutoItems();
67     this.updateModeItems();
68 #endif
69     this.updateOfflineApps();

I've noticed since Firefox shows the checked/enabled "Firefox" update while it isn't supposed to (update not possible because of a non-writable install location).

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Proposed patch upcoming

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

How about just removing the "return;" and reversing the condition instead?

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch #2

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/eba3f86ba79c

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 391131 [details] [diff] [review]
patch #2

Minor bugfix but with almost no risk (and interesting for Linux distributors shipping in non-writable locations)

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 391131 [details] [diff] [review]
patch #2

Too late for .3, moving to .4

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 391131 [details] [diff] [review]
patch #2

Approved for 1.9.1.4, a=dveditz for release-drivers

Comment 9

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dee350a17c4f

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified by examining code for 1.9.1.4.