Closed Bug 506929 Opened 13 years ago Closed 12 years ago

Ignore NO_EM_RESTART in the environment when make mozmill & make mozmill-one are set

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(thunderbird3.1 beta1-fixed, thunderbird3.0 .2-fixed)

RESOLVED FIXED
Thunderbird 3.1b1
Tracking Status
thunderbird3.1 --- beta1-fixed
thunderbird3.0 --- .2-fixed

People

(Reporter: standard8, Assigned: asuth)

References

Details

Attachments

(1 file)

If NO_EM_RESTART=1 is set, mozmill fails.

If it is set we should abort the run and tell the user. Maybe we could do this in runtest.py?
(In reply to comment #0)
> If NO_EM_RESTART=1 is set, mozmill fails.
> 
> If it is set we should abort the run and tell the user. Maybe we could do this
> in runtest.py?

That sounds the thing to do.
'tis better to fix than to complain; just remove it from the environment and get on with our lives.

This patch layers on top of my patch for bug 533246.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Attachment #417701 - Flags: review?(bugzilla)
Component: Build Config → Testing Infrastructure
QA Contact: build-config → testing-infrastructure
Depends on: 533246
Attachment #417701 - Flags: review?(bugzilla) → review+
(that's an r+ for when bug 533246 lands).
Summary: make mozmill & make mozmill-one should complain about NO_EM_RESTART being set → Ignore NO_EM_RESTART in the environment when make mozmill & make mozmill-one are set
Comment on attachment 417701 [details] [diff] [review]
v1 just remove NO_EM_RESTART from our inherited environment when present

a=Standard8 for test-only patch
Attachment #417701 - Flags: approval-thunderbird3.0.2+
Checked in:
http://hg.mozilla.org/comm-central/rev/42e3f50e4983
http://hg.mozilla.org/releases/comm-1.9.1/rev/3e7c6dacc0a5
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
Verifying MozMill test harness fix for 3.0.2 on the basis that MozMill tests are still running fine and no-one has complained.
You need to log in before you can comment on or make changes to this bug.