507000 - Hardware Key mapping for volume Up/Down getting overridden (wince)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[kantha kanchiraju]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.11) Gecko/2009060310 Ubuntu/8.10 (intrepid) Firefox/3.0.11
Build Identifier: Fennec 1.0a2

The Hardware Buttons Volume Up/Down get mapped to VK_F6/F7 on windows Mobile, accordign to the follwoing article http://msdn.microsoft.com/en-us/library/bb431750.aspx.

Fennec shouldnt map VK_F6 and VK_F7 to any of its functionality. Volume Controls should be left alone.


Reproducible: Always

Actual Results:  
VK_F6 is getting mapped to Fullscreen.
VK_F7 is getting mapped to Zoom in.

Expected Results:  
VK_F6 and VK_F7 should be used for controlling the volume.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

What's the plan for this? Which keys, if any would be good candidates?

Comment 2

[kantha kanchiraju]

Attachment: change the mappings for Wince devices

This patch uses the following Key bindings for WinCE Devices.
VK_F1 --> Zoom in
VK_F2 --> Zoom out
VK_F4 --> Quit

Comment 3

[Stuart Parmenter]

We may want to address this on Maemo too.  There have been a number of times when I've wanted to lower the volume of a plugin only to zoom :/

Comment 4

[Aakash Desai [:aakashd]]

This should probably be moved to NEW then as investigation of whether this should be addressed has already begun.

Comment 5

[kantha kanchiraju]

Should we remove the F7 and F8 mappings to Zoom in/out for maemo as well?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> Should we remove the F7 and F8 mappings to Zoom in/out for maemo as well?

No, the default browser on maemo uses F7 and F8 for zooming. If anything we could check to see if a plugin is active and adjust accordingly.

If needed, we'll open a new bug for Maemo.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mobile-browser/rev/0aa532ba98fc

Comment 8

[Aakash Desai [:aakashd]]

This'll break with HTC touch pro if you move to landscape mode seeing as how the volume buttons are unresponsive in that state...and in portrait mode are set as global volume buttons.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> This'll break with HTC touch pro if you move to landscape mode seeing as how
> the volume buttons are unresponsive in that state...and in portrait mode are
> set as global volume buttons.

The patch doesn't use the volumne controls for zooming on windows mobile.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

marking FIXED again

Comment 11

[Aakash Desai [:aakashd]]

What about fullscreen? It's still using VK_F6

I'm getting the volume control mapping from the following link:

http://msdn.microsoft.com/en-us/library/bb431750.aspx

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #11)
> What about fullscreen? It's still using VK_F6

It should not be using VK_F6 at all anymore

> 
> I'm getting the volume control mapping from the following link:
> 
> http://msdn.microsoft.com/en-us/library/bb431750.aspx

We are using F1 and F2 for volume + / -

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED on build: 

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090817 Fennec/1.0a3pre