507028 - Infinite loop when playing completely decoded media

Status: VERIFIED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: testcase

If we've completely decoded an ogg file, the nsOggDecodeStateMachine goes into DECODER_STATE_COMPLETED. In nsOggDecodeStateMachine::Run, the case that handles COMPLETED has a loop:

  // Play the remaining frames in the frame queue
  while (mState == DECODER_STATE_COMPLETED &&
         !mDecodedFrames.IsEmpty()) {
    PlayFrame();
    // ...
  }

That's wrong, as PlayFrame() won't play if we're not playing, so it won't pop a frame off mDecodedFrames, and we won't exit the loop. This results in the throbber not stopping.

STR: Seek to HTMLMediaElement.duration, you'll get a perpetual throbber.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

That loop should be:

  // Play the remaining frames in the frame queue
  while (mState == DECODER_STATE_COMPLETED &&
         mPlaying &&
         !mDecodedFrames.IsEmpty()) {
    PlayFrame();
    // ...
  }

The testcase should not have the throbbers. This bug prevents seeked events from firing, maybe that's a cause of intermittent test failures?

Comment 2

[Matthew Gregan [:kinetik]]

I just started running into this, but something causes the decoder to break out of the loop after 5 seconds or so (decoder shutdown externally?).

Comment 3

[Matthew Gregan [:kinetik]]

This is probably fixed by the new media backend.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #3)
> This is probably fixed by the new media backend.

Looks fixed to me.