507040 - "Restore Default Set" causes Toolbars to flicker

Status: RESOLVED WORKSFORME

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090727 Shiretoko/3.5.2pre ID:20090727031954

Clicking the "Restore Default Set" inside the customize dialog causes all toolbars to flicker. For a short moment the bookmarks toolbar shows its real content while the address bar takes all the space of the navigation toolbar.

With Minefield a resizing of the entries only happens when opening/closing the customize dialog.

Personally I can only see this behavior on OS X. But another user has been reported the same behavior by running a Litmus test.

Screencast: http://screencast.com/t/1PCca1ZA

It's a regression against Firefox 3.0.x.

Comment 1

[Nochum Sossonko [:Natch]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1

I see it on Vista as well. Add the new tab button to the toolbar, then hit restore default set.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On OS X I don't have to add the New Tab button. Even customizing the default toolbar set causes this flickering. Nochum, does it also happen when other toolbar buttons have been dragged to the toolbar?

Comment 3

[Nochum Sossonko [:Natch]]

Yeah, scratch that it doesn't need any customizing at all, just hitting the reset button does it. I think this bug is filed (or mentioned in another bug) already, something to do with bookmark toolbar expanding when customizing.

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

Error Console Output:
Error: a._updateVisibleText is not a function
Source file: chrome://global/content/bindings/textbox.xml
Line: 211
 ----------
Error: a.initialize is not a function
Source file: chrome://browser/content/search/search.xml
Line: 498

Regression Range/MC: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ca9d3c35fe47&tochange=9dbded90af2a

Regression Range/1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=7b4d7f11fefc&tochange=fe71edbb2925

=> overlap points to check-in of Bug 472302.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Error Console Output:
> Error: a._updateVisibleText is not a function
> Source file: chrome://global/content/bindings/textbox.xml
> Line: 211

There's no such line in textbox.xml. Bug 472302 actually removed it.

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

Yes, you are right. The actual output (using today's MC build) is only:

Error: a.initialize is not a function
Source file: chrome://browser/content/search/search.xml
Line: 491

Comment 7

[Dão Gottwald [:dao]]

That error is most likely unrelated to this bug, which I am unable to reproduce btw.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It does not happen with a trunk build. Seems like 1.9.1 only.

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

for me it is reproduceable with current MC build:
- new profile
- run Fx
- close Fx
- run Fx again
- View/Toolbars/Customize + hit button "Restore Default Set".

per hit on that button i get the error console output mentioned in comment 6 twice.
hitting that button on the first run of Fx the bug does not happen.

Comment 10

[(mostly gone) XtC4UaLL [:xtc4uall]]

this is now WFM (on trunk).
the flickering is gone - i guess (at least) with the fix for Bug 537171.
comment 6 is covered by Bug 521808.