Closed Bug 507047 Opened 15 years ago Closed 15 years ago

COWs don't need to override toString

Categories

(Core :: XPConnect, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

I realized that I forgot to address bug 480205 comment 37. The fix is to not do anything special for toString, since we don't have to do any sort of bypassing, just make sure if the toString implementation misbehaves and returns an object that the object is wrapped.
Attached patch Proposed fixSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #391240 - Flags: superreview?(jst)
Attachment #391240 - Flags: review?(jst)
Attachment #391240 - Flags: superreview?(jst)
Attachment #391240 - Flags: superreview+
Attachment #391240 - Flags: review?(jst)
Attachment #391240 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/981030c48c41
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: