507189 - New phonebook needs to work for LDAP admins

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Michael Morgan [:morgamic]]

Few things:
* edit page dies for LDAP admins - not sure why (max memory exhausted) but sounds like a bad loop
* LDAP admins don't need to see DISABLED accounts, so you could filter those so the phonebook is usable for them

Justin - anything else?

Comment 1

[Reed Loden [:reed]]

Pretty sure LDAP admins will need to see DISABLED accounts, as people get reactivated over time. Basically, by hiding DISABLED accounts, if anybody gets accidentally set to DISABLED, there's no way to change that back without going into phpLDAPadmin or doing ldapmodify directly.

Comment 2

[Michael Morgan [:morgamic]]

Right, people who have access can use the proper tool.  When Justin goes to lookup my IM so he can message me and talk about shopping, clothes and poodles, he doesn't need to see disabled accounts.

Comment 3

[Reed Loden [:reed]]

Except Karen and Erica don't have access to phpLDAPadmin, so they need to see DISABLED accounts via the phonebook interface.

Comment 4

[Aravind Gottipati [:aravind]]

Yeah, LDAP admins need to see DISABLED accounts.  The phonebook is HR's interface into LDAP.  If Justin doesn't want to see that stuff, we can always disable his admin privileges.

Comment 5

[Michael Morgan [:morgamic]]

Ok - whatever works.

Comment 6

[Michael Morgan [:morgamic]]

Wouldn't it be easier to have a separate section for DISABLED accounts and not have them floating around in the regular phonebook?  I'll ask Karen what she wants.

Comment 7

[Justin Fitzhugh]

If the behavior is desired, then it's fine.  I'd go off aravind's comment #4 and leave it as is.

As for the second item, still stands as admins can't edit people.

Comment 8

[Reed Loden [:reed]]

(In reply to comment #6)
> Wouldn't it be easier to have a separate section for DISABLED accounts and not
> have them floating around in the regular phonebook?  I'll ask Karen what she
> wants.

Sure, that's fine, and I think that's a great idea.