Closed Bug 507214 Opened 12 years ago Closed 12 years ago

Add a src parameter to all install/download buttons

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fligtar, Assigned: rdoherty)

References

Details

Attachments

(1 file)

We should have a src= parameter for every add-on install/download button.

I am aware of the following locations that are missing them currently:

* Category pages (src=category) (include general add-on type pages here, like Search Tools, Themes, etc.)
* Search pages (src=search)
* Collection pages (src=collection) (we currently have collection_id which says the specific collection, but we need a src parameter)
* Recommended page (src=recommended)
* Tabs in homepage browse section (src=homepagebrowse)
I thought we added a src to the API download link, but looks like it was only the learnmore link?

https://preview.addons.mozilla.org/en-US/firefox/api/1.1/search/web%20developer/all/10/Darwin/3.0.6

So, one more:
* API (src=api)
I'd like to roll this in to the rewrite
Depends on: 498825
Target Milestone: 5.0.9 → ---
Priority: -- → P1
Target Milestone: --- → 5.2
Blocks: 518705
Assignee: nobody → rdoherty
Blocks: 520635
Attached patch v1Splinter Review
Added src parameters where specified.
Attachment #404716 - Flags: review?(ddahl)
Attachment #404716 - Flags: review?(ddahl) → review?(dd)
r52970
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Keywords: push-needed
Verified on preview for Collections, HomePage browse category pages and Search pages.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.