Add a src parameter to all install/download buttons

VERIFIED FIXED in 5.2

Status

defect
P1
normal
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: fligtar, Assigned: rdoherty)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

Reporter

Description

10 years ago
We should have a src= parameter for every add-on install/download button.

I am aware of the following locations that are missing them currently:

* Category pages (src=category) (include general add-on type pages here, like Search Tools, Themes, etc.)
* Search pages (src=search)
* Collection pages (src=collection) (we currently have collection_id which says the specific collection, but we need a src parameter)
* Recommended page (src=recommended)
* Tabs in homepage browse section (src=homepagebrowse)
Reporter

Updated

10 years ago
Blocks: 507221
Reporter

Comment 1

10 years ago
I thought we added a src to the API download link, but looks like it was only the learnmore link?

https://preview.addons.mozilla.org/en-US/firefox/api/1.1/search/web%20developer/all/10/Darwin/3.0.6

So, one more:
* API (src=api)
I'd like to roll this in to the rewrite
Depends on: 498825
Target Milestone: 5.0.9 → ---
Reporter

Updated

10 years ago
Priority: -- → P1
Target Milestone: --- → 5.2
Reporter

Updated

10 years ago
Blocks: 518705
Reporter

Updated

10 years ago
Assignee: nobody → rdoherty
Assignee

Updated

10 years ago
Blocks: 520635
Assignee

Comment 3

10 years ago
Posted patch v1Splinter Review
Added src parameters where specified.
Attachment #404716 - Flags: review?(ddahl)
Assignee

Updated

10 years ago
Attachment #404716 - Flags: review?(ddahl) → review?(dd)
Assignee

Comment 4

10 years ago
r52970
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Assignee

Updated

10 years ago
Keywords: push-needed
Verified on preview for Collections, HomePage browse category pages and Search pages.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.