Please QA the "1 Billion + You" campaign micro-site

VERIFIED FIXED

Status

www.mozilla.org
General
--
major
VERIFIED FIXED
9 years ago
5 years ago

People

(Reporter: stephend, Assigned: mozwebqa)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
We should test the "1 Billion Downloads + You" campaign's micro-site.

It'll be live on August 3rd, up at onebillionplusyou.com.

Staging server details @ silverorange.com have been sent to the team members.
(Reporter)

Updated

9 years ago
Assignee: jen → stephen.donner

Updated

9 years ago
Blocks: 507138
(Reporter)

Updated

9 years ago
Assignee: stephen.donner → mozwebqa
(Reporter)

Comment 1

9 years ago
Steven, site looks good; Raymond tested browser compatibility, functionality, and checked all links -- the only issue we could find was one small doctype validation error:

Line 168, Column 129: Attribute "target" exists, but can not be used for this element.

…onclick="return fbs_click()" target="_blank">Post on Facebook</a></li>
Bug: the bit.ly URL in "Post to Twitter" and "Post to Facebook" links are dead links.

Currently: http:/+it.ly/12oBwA
Should be: http://bit.ly/12oBwA

This impacts 6 links on the page and should be updated on all locale pages.
(Reporter)

Comment 3

9 years ago
I don't see any bit.ly links on http://one-billion-trunk.mozilla.silverorange.com
(Reporter)

Comment 4

9 years ago
(In reply to comment #3)
> I don't see any bit.ly links on
> http://one-billion-trunk.mozilla.silverorange.com

nvm; William explained how and why bit.ly does what it does (tracker).  Just clicking through the links, we didn't catch this.  Sorry for the misunderstanding, William; nice catch!
The bit.ly links are fixed in trunk, it does not affect localization work. Good catch.
(Reporter)

Comment 6

9 years ago
(In reply to comment #5)
> The bit.ly links are fixed in trunk, it does not affect localization work. Good
> catch.

Thx; just checked and verified.
The target="_blank" has been removed and the site now validates. Removing it
causes the Facebook link to open in the same Window if JavaScript is disabled,
but that's not too bad.
The final "Post to Twitter" link to the right of "Or write your own and share it with the world!" sets the user's Twitter status with the wrong message.

Currently: How much is a billion? One billion kilograms is equal to the weight of 27000 elephants. http://bit.ly/12oBwA #fxbillion
Should be: http://bit.ly/12oBwA #fxbillion
The en-US page currently has the metric units for "How much is a billion?" facts 2 and 5. They should be updated to American units as follows:

- One billion stacked coins would reach nearly 1,000 miles high.
- One billion kilograms is equal to the weight of 60,000 elephants.

Also, please check that "Post to Twitter" links next to these facts are updated with the correct numbers and units.

Note: This should *only* be changed for the en-US page. Thanks!
Just noticed that the pictures in the billion facts don't match up with the facts. This happened because we moved one of the facts but did not update the order of the pictures. The pictures should appear in this order:

Goldfish
Coins
Globe
Clock
Elephant
Whale
Question mark

Please update the order.
Also, in the phrase "fifty two blue whales", the words "fifty-two" should have a hyphen in between to be grammatically correct.

*Only applies to en-US page
(Reporter)

Comment 12

9 years ago
Created attachment 391827 [details] [diff] [review]
Patch

1) Reorders the list-item elements to the order suggested by William; don't know if this actually fixes the problem, though, since I haven't yet generated/served HTML from PHP.
2) Changes "1600 kilometers" to "1,000 miles high"
3) Changes "27000 elephants" to "60,000 elephants"
4) Adds a hyphen to "fifty-two blue whales" (compound modifier)
Attachment #391827 - Flags: review?(steven)
(Reporter)

Updated

9 years ago
Attachment #391827 - Attachment is patch: true
Attachment #391827 - Attachment mime type: application/octet-stream → text/plain
(In reply to comment #1)
> Steven, site looks good; Raymond tested browser compatibility, functionality,
> and checked all links -- the only issue we could find was one small doctype
> validation error:
> 
> Line 168, Column 129: Attribute "target" exists, but can not be used for this
> element.
> 
> …onclick="return fbs_click()" target="_blank">Post on Facebook</a></li>

We could fix this with JavaScript. We just need to add a piece of JS code and then we could force(with rel="something") every link on the page to open in a new tab.
Created attachment 391844 [details]
What about this?
Milos, the target="_blank" is only used if JavaScript is disabled. There's already JavaScript code to open the Facebook link in a new Window.

Good catch with the script 404. Fortunately, it seems to be the only one. Fixed in trunk.
Pascal,

The out-of-order facts will potentially affect translators. Has the page been sent to the translation team yet?

Also, several en-US fixes have been mentioned on this bug. Can I get confirmation that the generic locale 'en' should use the en-US localization?
William, re Comment #8, this has been fixed in trunk.
'en' is for en-US

Nothing sent to translators yet, the site was not stable enough for that.
http://one-billion-trunk.mozilla.silverorange.com/img/twitter-background.png

remove the 1 billion and put '1 000 000 000' (no comas) instead. English is the only language where billion is 1 plus 9 zeros, for all languages it is 1 plus 12 zeros.
(In reply to comment #19)
> http://one-billion-trunk.mozilla.silverorange.com/img/twitter-background.png
> 
> remove the 1 billion and put '1 000 000 000' (no comas) instead. English is the
> only language where billion is 1 plus 9 zeros, for all languages it is 1 plus
> 12 zeros.

I totally agree with you.
Comment #9, Comment #10, Comment #11, Comment #12 and Comment #18 have been dealt with. The 'en' locale is updated to use imperial units and the order of the twitter links and images has been fixed.

Is there a reason centimeters and kilograms were left as metric units, or should those be changed as well?
Does the staging site runs on a cron job taking files from svn ? if so, how often does it run?
Re: Comment #19 and Comment #20, the image has been updated with a non-text
Twitter birdie.

The existing Twibbon (http://twibbon.com/join/1-billion-Firefox-downloads) has
the same localization problem and already has 552 supporters. If that is
changed, please send an updated link.
I have warnings for variables that are set :
Notice: Undefined variable: langTitle in /so/sites/mozilla/one-billion-trunk/fr/index.php on line 198

comment #22?

Comment 25

9 years ago
(In reply to comment #19)
> http://one-billion-trunk.mozilla.silverorange.com/img/twitter-background.png
> 
> remove the 1 billion and put '1 000 000 000' (no comas) instead. English is the
> only language where billion is 1 plus 9 zeros, for all languages it is 1 plus
> 12 zeros.

Careful classifying "all languages" with what contintental Europe and many other languages use for their numbering systems.   

When referring to long and short scale, I found this reference document helpful http://en.wikipedia.org/wiki/Long_and_short_scales

From that article, you'll read, "Many countries, including most in continental Europe, use the long scale. There are other numbering systems which are neither long nor short scale such as the Chinese numbering system, the Indian numbering system, the Japanese numbering system, and the Korean numbering system."  

It appears the our India, Chinese, Japanese, and Korean localization teams may also have different requirements.
http://one-billion-trunk.mozilla.silverorange.com/?lang=en

the mozilla logo and visit mozilla.com links are wrong

Comment 27

9 years ago
Regarding the links in the header (the logo / visit mozilla) should we localize the link or is there a more robust lang relocte available on mozilla.com to use instead?
(In reply to comment #27)
> Regarding the links in the header (the logo / visit mozilla) should we localize
> the link or is there a more robust lang relocte available on mozilla.com to use
> instead?

What is 'relocte'? For the locales version, I point those links to http://www.mozilla.com we have locale detection there that will do the job.
Pascal, re Comment #26 and Comment #28, s/relocte/redirect, and the header links now point to http://www.mozilla.com/ in the en/index.php in trunk.
(Reporter)

Updated

9 years ago
Attachment #391827 - Attachment is obsolete: true
Attachment #391827 - Flags: review?(steven)
Update: new staging site at http://onebillion.stage.mozilla.com/
(Reporter)

Comment 31

9 years ago
There's code at the bottom right, near the locale switcher:

html[lang=fr] #mozillas-mission h3, #twibbon h3 { padding-right:65px; }
good catch Stephen, unvoluntary pasting of what I had in my clipboard, fixed in r48295
https://bugzilla.mozilla.org/show_bug.cgi?id=507680#c8
interesting feedback on the weight of an elephant...
The current omniture code is causing a HTTP request every time the next/prev arrows on the pager are clicked. This adds an undesirable half-second delay when switching pages.

See also Bug #507238.

What's the best way to fix this?
(Reporter)

Comment 35

9 years ago
Michael, please file a separate bug for comment 34.  Site has shipped, had its participating locales added, and looks good.

Resolving -> fixed.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
http://www.onebillionplusyou.com/ verified fixed
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.