507296 - Sync bookmarks and history in batched mode

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ed Lee :Mardak]

Batched mode for creating bookmarks means we don't cause sqlite to write to disk on every created bookmark and only do so after all the bookmarks have synced.

I ran a test with my profile with ~650 fat bookmarks (10KB each) with sync time instrumentation from bug 506321.

All the following use close to latest 1.9.2a1pre and are number of seconds to apply the incoming ~650 bookmarks. Entries with * are for batched results:

samsung nc10: 361
dell mini 10: 360
fennec n810: 219
* fennec n810: 127
macbook 13": 12
* samsung nc10: 11
* dell mini 10: 11
* macbook 13": 5

So devices with slow disks get a ton of improvement, and a "real profile" with small bookmarks could see more gains assuming the improvements come from getting rid of per-write overheads.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Dan Mills [:thunder]]

Comment on attachment 391491 [details] [diff] [review]
v1

Awesome! :)
r=thunder

Comment 3

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/4899f703a5d7
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.

Comment 5

[Tony Chung [:tchung]]

flagging in-testsuite? for unit test?