507300 - Get Mozmill running from the command line on Windows from within the build system

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now it is not possible to run the mozmill command line script on Windows with the Build System 1.4 installed. We miss the pywin32 extensions. See bug 507259.

Mikeal did already a change to dismiss the win32job module. But that's not all. After upgrading mozrunner from svn I get the following error:

$ pywin32 is not installed. Some wait() features in killableprocess may not func
tion properly.
Traceback (most recent call last):
  File "c:\mozilla-build\python25\Scripts\mozmill-restart-script.py", line 8, in
 <module>
    load_entry_point('mozmill==1.2', 'console_scripts', 'mozmill-restart')()
  File "c:\mozilla-build\python25\lib\site-packages\setuptools-0.6c9-py2.5.egg\p
kg_resources.py", line 277, in load_entry_point
  File "c:\mozilla-build\python25\lib\site-packages\setuptools-0.6c9-py2.5.egg\p
kg_resources.py", line 2180, in load_entry_point
  File "c:\mozilla-build\python25\lib\site-packages\setuptools-0.6c9-py2.5.egg\p
kg_resources.py", line 1913, in load
  File "c:\mozilla-build\python25\lib\site-packages\mozmill-1.2-py2.5.egg\mozmil
l\__init__.py", line 48, in <module>
    import jsbridge
  File "c:\mozilla-build\python25\lib\site-packages\jsbridge-2.0-py2.5.egg\jsbri
dge\__init__.py", line 44, in <module>
    import mozrunner
  File "/Volumes/data/build/mozrunner/mozrunner/__init__.py", line 65, in <modul
e>
ImportError: No module named win32api

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mikeal, win32api is also part of pywin32. Given the following line in __init__.py we have some more modules from that package:

import win32api, win32pdhutil, win32con

Would it be possible to get rid of them or do we always need them?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mikeal? Do you think it is worth getting it run inside the build system? Installing Python, Pywin32, and setuptools in parallel works fine for me. Punting for future?

Comment 3

[Mikeal Rogers [:mikeal] (mrogers@)]

On the testdev call I suggested we prioritize Mac and Linux running in buildbot and deal with Windows once we're already sorted out Mac and Linux.

This issue will certainly come back up once we go tackle Windows again but for now we can punt it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Yeah, we can get it working in the following way. So lets punt it.

https://developer.mozilla.org/en/Mozmill#Windows

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ted, would it be at least possible for now to add the necessary registry entries which are needed for Python extensions? See https://developer.mozilla.org/en/Thunderbird/Thunderbird_MozMill_Testing#Windows how it is done by the Thunderbird guys. That would be a big help so users don't have to handle the registry stuff on their own.

Comment 6

[Mikeal Rogers [:mikeal] (mrogers@)]

Forgot to mention this in the other bug about htis.

pywin32 is only used for killableprocess.Popen.wait() on Windows. I wrote this for the killableprocess module we keep in mozrunner so it's not in any of killableprocess module.

If someone has a reliable way to wait for the processes using ctypes instead of pywin32 I would be happy to remove the dependency.

Comment 7

[(not currently active) Ted Mielczarek]

I'd rather not make MozillaBuild write anything to the registry from the installer. I'd be fine with shipping a script with MozillaBuild that users could run to register its Python in the registry, though.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> pywin32 is only used for killableprocess.Popen.wait() on Windows. I wrote this
> for the killableprocess module we keep in mozrunner so it's not in any of
> killableprocess module.
> 
> If someone has a reliable way to wait for the processes using ctypes instead of
> pywin32 I would be happy to remove the dependency.

Benjamin mentioned on bug 507259 that he wrote his killableprocess with ctypes. Hopefully he can help us.

Comment 9

[(not currently active) Ted Mielczarek]

His code is here:
http://svn.smedbergs.us/python-processes/trunk/

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has been fixed in Mozmill 1.4 by removing the pywin32 dependency.