Closed
Bug 507326
Opened 15 years ago
Closed 15 years ago
CGIs pass "target" to templates, but it gets overwritten by the login form template in the header
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: mkanat, Assigned: mkanat)
Details
(Whiteboard: [es-gnome])
Attachments
(1 file)
1.67 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
The login form in the header uses the variable "target" to choose what the form target should be, but there are certain times when "target" is actually a variable that's being passed to the templates, meaning that the header is overwriting it. Thankfully this doesn't affect any critical functionality, but it will result in strange messages and so forth on certain pages.
Flags: blocking3.4.1+
Assignee | ||
Comment 1•15 years ago
|
||
Comment 2•15 years ago
|
||
Comment on attachment 391532 [details] [diff] [review] v1 Looks good. r=LpSolit But as I said on IRC, I checked all templates and CGIs using "target", and none is affected by this problem, AFAICS. So this is just to prevent future possible problems.
Attachment #391532 -
Flags: review?(LpSolit) → review+
Updated•15 years ago
|
Flags: approval3.4+
Flags: approval+
Assignee | ||
Comment 3•15 years ago
|
||
tip: Checking in template/en/default/account/auth/login-small.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v <-- login-small.html.tmpl new revision: 1.20; previous revision: 1.19 done 3.4: Checking in template/en/default/account/auth/login-small.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v <-- login-small.html.tmpl new revision: 1.17.2.3; previous revision: 1.17.2.2 done
Severity: normal → minor
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Whiteboard: [es-gnome]
You need to log in
before you can comment on or make changes to this bug.
Description
•